From user-return-12431-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Dec 13 01:26:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7623518061A for ; Fri, 13 Dec 2019 02:26:14 +0100 (CET) Received: (qmail 4463 invoked by uid 500); 13 Dec 2019 01:26:12 -0000 Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@zookeeper.apache.org Delivered-To: mailing list user@zookeeper.apache.org Received: (qmail 4450 invoked by uid 99); 13 Dec 2019 01:26:12 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Dec 2019 01:26:12 +0000 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 67DD64FB3 for ; Fri, 13 Dec 2019 01:26:12 +0000 (UTC) Received: by mail-qv1-f51.google.com with SMTP id t5so215818qvs.5 for ; Thu, 12 Dec 2019 17:26:12 -0800 (PST) X-Gm-Message-State: APjAAAXfyECLWcKUUASvhwco4xZiOXviTXg5tdjavm4BahRuQGJd01Az o3sae/lmCzZWMsXjSZ5nepbU/v3xs8h6s/BWmQc= X-Google-Smtp-Source: APXvYqwo35MEvZyWWxGnP6LA7fWtIK9tedhP1x0Zj70PTvhEA7X3lBtK3tb27tyVljW1iJek3Wg/AWhQoNNTs412olw= X-Received: by 2002:a0c:e806:: with SMTP id y6mr11023629qvn.148.1576200372173; Thu, 12 Dec 2019 17:26:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Michael Han Date: Thu, 12 Dec 2019 17:26:01 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: clientCnxnSocket#updateLastSendAndHeard() method usage To: user Content-Type: multipart/alternative; boundary="0000000000004740e905998bbff9" --0000000000004740e905998bbff9 Content-Type: text/plain; charset="UTF-8" We had some prod issues previously related to the usage of cached "now" variable (and lacking of consistent accessing pattern for updateNow) used in java client - we had a patch internally (basically what's described in ZOOKEEPER-2471) that removed usage of the cache value and instead calculate "now" whenever we need. On Wed, Dec 11, 2019 at 8:35 PM Karan Mehta wrote: > Hello, > > On this line in ClientCnxn.java > < > https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java#L1183 > >, > we are calling clientCnxnSocket.updateLastSendAndHeard() method but we > didn't call clientCnxnSocket.updateNow() method before that. Is there a > possiblity that can result in incorrect calculation > of clientCnxnSocket.getIdleRecv(), causing it to > throw SessionTimeoutException? > > -- > Karan Mehta > > > --0000000000004740e905998bbff9--