From user-return-12129-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Sep 13 05:30:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 60A8A180652 for ; Fri, 13 Sep 2019 07:30:08 +0200 (CEST) Received: (qmail 98594 invoked by uid 500); 13 Sep 2019 05:30:05 -0000 Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@zookeeper.apache.org Delivered-To: mailing list user@zookeeper.apache.org Received: (qmail 98570 invoked by uid 99); 13 Sep 2019 05:30:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Sep 2019 05:30:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A0027180D05; Fri, 13 Sep 2019 05:30:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id zF8Nf3cPU_qr; Fri, 13 Sep 2019 05:29:59 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::243; helo=mail-oi1-x243.google.com; envelope-from=eolivelli@gmail.com; receiver= Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 011B37DD60; Fri, 13 Sep 2019 05:29:58 +0000 (UTC) Received: by mail-oi1-x243.google.com with SMTP id w144so1202652oia.6; Thu, 12 Sep 2019 22:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p5lZic8QQraE9uwk54khf+wydOudtNMPuiMUb3UQ31Q=; b=InGIPjcF1v72aVBpfhgDei5jgArcXI6+qPO98/Y16Ixi1ShDHHkNi55rjTjwCL4EtP L9L4pXoUUruPRLDmiqJ7+V32GvEGRz40x42CYeU5XsD7HIktMUkeqWxREShnzDQjV+91 CSSAg6jLCxQO0iUUtjjj6njYGWUmgEPEmWKPQHCxz91m0rpymsawomSQXJbX03o9fBaF 1DxFkqPrYrxdEzfwnSSkesmV40MeLAhKPABxqC9M+mDUjwMFTyTxkWaaYr8cLYB5NKEs eUCOAxTEmMcTgp6Tf0iUQ8i3AsJSLSM6HwEiNGPRjEI+PGKHTnIHtDAQtbi31aZl+CjF DFdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p5lZic8QQraE9uwk54khf+wydOudtNMPuiMUb3UQ31Q=; b=J/PLVOGgryKghj8HNTIkQP4s/xeOxw1SCb90po1dhWnxXrhq4LpGB1HnlXG+wBMkA5 EoeBYK/tgHlZV538sqQo3XMb20LUomu5PuGge+89aCoRMPpNsEkBi9pcqFE8U3pLbTQk Q3q/90NlzxCKCCKFlZ/QuhKoz2Z5o9VQsW5C0omM5YDK9zu52vlB5GS8QB+qwLOGS32P sQnOYvy/sAGM5pWFgwyZXwa5eMEkhkVJ8mmbnpavt1xWPCAK63t+c/fCHRYfeWVS69Ps T9Bzp/QLtMK7q85tjFq2w5qT522kAJBa3lKqzv84BXgwmVrqCBfNYWdFSo5fvHaLjxz3 6mcw== X-Gm-Message-State: APjAAAV+dSZFUYBhjpdrrPua9wColhupjzW8ncVazuTE9OGWCDltxIcM 1DGGWTjvtgG1kptLrkcqDZrSflqetFoIq+KSD0Vj6g== X-Google-Smtp-Source: APXvYqysPnxqmfqx1gJXgVnjVsKLNrvnyE/IYYltdvkVkIlkf4kvyejBLMK/Khaosfx8hoNOUXusSI0En0NCw9Ve/os= X-Received: by 2002:aca:b4d7:: with SMTP id d206mr848733oif.139.1568352592212; Thu, 12 Sep 2019 22:29:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Enrico Olivelli Date: Fri, 13 Sep 2019 07:29:41 +0200 Message-ID: Subject: Re: [RFR] ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed To: dev@zookeeper.apache.org Cc: user@zookeeper.apache.org Content-Type: multipart/alternative; boundary="0000000000002435580592688b50" --0000000000002435580592688b50 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Zili, Thank you for driving this. We must ensure that that change does not break 100% compatibility with 3.4 client. The best way to prove it is to setup some integration test that tests a compatibility matrix, it will be an huge work. In absence of that facility we need some Jute expert to review the change. Personally I don't have much cycles to study jute these days. Enrico Il gio 12 set 2019, 01:37 Zili Chen ha scritto: > I met this issue again when working on Pravega[1], a project using > ZooKeeper. > > I think it is nice to have that we throw the exactly path that cause the > multi-op fails. > > Could you help to review the pull request? > > Best, > tison. > > [1] https://github.com/pravega/pravega/pull/4140#discussion_r322096138 > > > Zili Chen =E4=BA=8E2019=E5=B9=B48=E6=9C=8825=E6=97= =A5=E5=91=A8=E6=97=A5 =E4=B8=8A=E5=8D=884:19=E5=86=99=E9=81=93=EF=BC=9A > > > Hi ZooKeepers, > > > > ZOOKEEPER-3290 has been revived and here is its pull request[1]. > > > > Basically it extends field of ErrorTxn/ErrorResponse/ErrorResult to > > reflect accurate path info when a transaction failed. For example, > > assumed we do check1(path1)-create1(path2) and fail with > > NoNodeException, previously we don't know it is because absence of > > path1? or path2? or parent of one of them? Now we will throw a > > KeeperException with the accurate path that cause it. > > > > For instance, > > > > ZooKeeper zk =3D new ZooKeeper(...); > > > > zk.multi(List.of( > > Op.check("/path1", -1), > > Op.create("/path2", ...))); > > > > formerly throw with > > > > Exception in thread "main" > > org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = =3D > > NoNode > > > > but now > > > > Exception in thread "main" > > org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = =3D > > NoNode for /path1 > > > > Theoretically Jute is fine with this change so that we don't need to > worry > > about compatibility issue. Please checkout the branch if you are > > interested > > in this feature. > > > > Any feedback includes things work as expected is welcome. > > > > Best, > > tison. > > > > [1] https://github.com/apache/zookeeper/pull/839 > > > --0000000000002435580592688b50--