Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@zookeeper.apache.org
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: ZooKeeper dependencies
From: Flavio Junqueira <fpj@apache.org>
In-Reply-To: 
 <CAL5zq9bEa789BpEmTA-Gn_6kXEh_2PECrPg2fo8A3x+HEarnqw@mail.gmail.com>
Date: Fri, 20 Nov 2015 22:35:03 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <C263BF4F-B863-44C3-9D27-EA226E325A11@apache.org>
References: 
 <CAL5zq9bBLzODqLrG1iY4a==Fn3HPG3B70x3keQpfnpcnnDZ1XQ@mail.gmail.com>
 <47BB9C56-5205-4051-BA52-CBD66177E584@apache.org>
 <CAL5zq9bEa789BpEmTA-Gn_6kXEh_2PECrPg2fo8A3x+HEarnqw@mail.gmail.com>
To: user@zookeeper.apache.org

Happy to help!

> On 20 Nov 2015, at 19:51, Christopher <ctubbsii@apache.org> wrote:
>=20
> Thanks for the info. What's the best way to distinguish between
> dependencies needed for core and contrib?

I'd say you just list the dependencies in the ivy.xml file under the =
project root.

>=20
> I'm not really an ant/ivy developer, and just trying to help out with
> this package created by another Fedora maintainer. I'm much more
> familiar with maven builds.
>=20
> It does look like we're including some of the contrib stuff in this
> package. I'm not sure why. We probably shouldn't be, unless we put
> them in separate RPMs (subpackages). I'll look into separating them a
> bit in the future. As for license, it looks like BSD was included
> because of the hashtable bits which are compiled into the shared
> library? SLF4J isn't packaged in this, it's just a dependency, so its
> license is specified in its own RPM.

Here is what you'll find at the bottom of the LICENSE file:

This distribution bundles jline 0.9.94, which is available under the
2-clause BSD License. For details, see a copy of the license in
lib/jline-0.9.94.LICENSE.txt

This distribution bundles SLF4J 1.6.1, which is available under the MIT
License. For details, see a copy of the license in
lib/slf4j-1.6.1.LICENSE.txt

This distribution bundles a modified version of 'JZLib' as part of
Netty-3.7.0, which is available under the 3-clause BSD licence. For
details, see a copy of the licence in META-INF/license/LICENSE-jzlib.txt
as part of the Netty jar in lib/netty-3.7.0.Final.jar.

We ship slf4j in our artifact, that's why we list its license, perhaps =
you don't need it as you say.

>=20
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>=20
>=20
> On Thu, Nov 19, 2015 at 12:41 PM, Flavio Junqueira <fpj@apache.org> =
wrote:
>> Hi Christopher,
>>=20
>> I had a look and couldn't see any major problem. You seem to be =
including dependencies for both core and contrib. Just keep in mind that =
contrib contains projects that aren't active and consequently might not =
build or run properly. You may also want to MIT to the list of licenses. =
slf4j is under that license.
>>=20
>> -Flavio
>>=20
>>> On 16 Nov 2015, at 16:43, Christopher <ctubbsii@apache.org> wrote:
>>>=20
>>> Hi all,
>>>=20
>>> I'm trying to remove unneeded dependencies and classpath items from
>>> ZooKeeper, as packaged in Fedora.
>>>=20
>>> If I could get somebody to review the Requires and BuildRequires for
>>> anything obvious:
>>> http://pkgs.fedoraproject.org/cgit/zookeeper.git/tree/zookeeper.spec
>>>=20
>>> and the default zkEnv.sh CLASSPATH=3D... items for any obvious =
problems:
>>> http://pkgs.fedoraproject.org/cgit/zookeeper.git/tree/zkEnv.sh
>>>=20
>>> I would very much appreciate it. This would also help get ZooKeeper
>>> packaged for EPEL7, by reducing the work needed to package =
unnecessary
>>> dependencies there.
>>>=20
>>> Thanks,
>>>=20
>>> Christopher
>>=20