Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@zookeeper.apache.org
MIME-Version: 1.0
In-Reply-To: <8E75D5F2-C4A5-49A1-87BE-35EBCF5B590C@yahoo.com>
References: <8E75D5F2-C4A5-49A1-87BE-35EBCF5B590C@yahoo.com>
Date: Tue, 4 Aug 2015 11:44:29 -0400
Message-ID: 
 <CAKF1A=uJCBqD0S3jSk3DqKXFpt4foU2JZrip+pnb7y3j=opyAw@mail.gmail.com>
Subject: Re: LocalPeerBean getState() Possibly Incorrect
From: Camille Fournier <camille@apache.org>
To: "bookkeeper-user@zookeeper.apache.org" <user@zookeeper.apache.org>
Content-Type: multipart/alternative; boundary=047d7b3a81ea6300e4051c7e295a

--047d7b3a81ea6300e4051c7e295a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Yup that's a bug alright. Please feel free to file a ticket and even better
file a ticket and submit a patch.

Thanks,
C

On Tue, Aug 4, 2015 at 11:37 AM, Kevin Lee <kglee79@yahoo.com.invalid>
wrote:

> Hi,
>
> When performing some JMX investigation and looking at the =E2=80=9CState=
=E2=80=9D within
> the LocalPeerBean, I noticed the state was =E2=80=9CRunnable=E2=80=9D.  S=
o I downloaded the
> Zookeeper source code and took a look at LocalPeerBean.java in
> org/apache/zookeeper/server/quorum.  It appears that it is returning
> =E2=80=9Cpeer.getState().toString()=E2=80=9D which I do not believe was t=
he intent here
> because peer.getState() is returning the =E2=80=9CThread=E2=80=9D state, =
not the server
> state as the comment says it should be in =E2=80=9CLocalPeerMXBean.java=
=E2=80=9D.  To get
> the server state it should be doing a =E2=80=9Cpeer.getServerState()=E2=
=80=9D which will
> use the getServerState() method on the QuorumPeer class from which it is
> retrieving the state.  So the states would be =E2=80=9Cfollowing=E2=80=9D=
, =E2=80=9Cleading=E2=80=9D, etc
> instead of the Java thread states.
>
> Does anyone know if this a bug that needs to be addressed or if it is
> working as intended?
>
> Thanks,
> Kevin

--047d7b3a81ea6300e4051c7e295a--