Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@zookeeper.apache.org
Received-SPF: pass (nike.apache.org: domain of sslavic@gmail.com designates
 74.125.82.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <C2496325850AA74C92AAF83AA9662D26458CE37D@szxeml561-mbx.china.huawei.com>
References: 
 <CAAUywg9-ad3oWfqRWahB9PyBEbg6+d=Dyj5PAUU7A=m9wRncaw@mail.gmail.com>
	<C2496325850AA74C92AAF83AA9662D26458CE37D@szxeml561-mbx.china.huawei.com>
Date: Tue, 2 Sep 2014 09:25:04 +0200
Message-ID: 
 <CAAUywg_QXfRF2EKz2r_TvC1zOeRX=3rZaJMMLhwiNM84CQm0ow@mail.gmail.com>
Subject: Re: ServerCnxnFactory startup order and registering ZooKeeperServer
 JMX MBean
From: =?UTF-8?Q?Stevo_Slavi=C4=87?= <sslavic@gmail.com>
To: Rakesh R <rakeshr@huawei.com>
Cc: "user@zookeeper.apache.org" <user@zookeeper.apache.org>
Content-Type: multipart/alternative; boundary=001a11c348f0b12d690502100472

--001a11c348f0b12d690502100472
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Rakesh,

Thanks for fast response! I've created a ticket and submitted a patch:
https://issues.apache.org/jira/browse/ZOOKEEPER-2026

Kind regards,
Stevo Slavic.


On Tue, Sep 2, 2014 at 7:30 AM, Rakesh R <rakeshr@huawei.com> wrote:

> Hi Stevo Slavic,
>
> Yes, its very nice observation. I think this has to be corrected.
>
> Could you raise a JIRA ticket and add these details in that for further
> discussion.
>
> Regards,
> Rakesh
>
> -----Original Message-----
> From: Stevo Slavi=C4=87 [mailto:sslavic@gmail.com]
> Sent: 02 September 2014 03:08
> To: user@zookeeper.apache.org
> Subject: ServerCnxnFactory startup order and registering ZooKeeperServer
> JMX MBean
>
> Hello ZooKeeper community,
>
> When running ZK (3.4.6) related tests in parallel in same JVM, multiple
> servers although assigned a different local port clash when trying to
> register JMX MBean for server (see [1]) - the two get assigned same MBean
> name. Registering JMX MBean for ZooKeeperServer it seems cannot be
> disabled, not even for tests.
>
> Looking into ZooKeeperServerBean constructor, and
> ZooKeeperServer.getClientPort one can see that the MBean name will clash
> only when server connection factory is not bound to server, before startu=
p
> method of server connection factory gets called.
> This is exactly what happens in startup methods of both
> NIOServerCnxnFactory and NettyServerCnxnFactory, because of IMO wrong ord=
er
> that the methods are being called. Instead of current [2] IMO it should b=
e
> [3] or at least [4].
>
> Is my understanding wrong? If not, is this a (known) bug?
>
> Kind regards,
> Stevo Slavic
>
>
> [1] example build output fragment with failing ZK server JMX MBean
> registration
> javax.management.InstanceAlreadyExistsException:
> org.apache.ZooKeeperService:name0=3DStandaloneServer_port-1
>         at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:43=
7)
>         at
>
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithReposit=
ory(DefaultMBeanServerInterceptor.java:1898)
>         at
>
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBea=
n(DefaultMBeanServerInterceptor.java:966)
>         at
>
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(Defa=
ultMBeanServerInterceptor.java:900)
>         at
>
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(Defau=
ltMBeanServerInterceptor.java:324)
>         at
>
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:=
522)
>         at
> org.apache.zookeeper.jmx.MBeanRegistry.register(MBeanRegistry.java:96)
>         at
>
> org.apache.zookeeper.server.ZooKeeperServer.registerJMX(ZooKeeperServer.j=
ava:377)
>         at
>
> org.apache.zookeeper.server.ZooKeeperServer.startup(ZooKeeperServer.java:=
410)
>         at
>
> org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFac=
tory.java:123)
>
>
>
> [2]
>     @Override
>     public void startup(ZooKeeperServer zks) throws IOException,
>             InterruptedException {
>         start();
>         zks.startdata();
>         zks.startup();
>         setZooKeeperServer(zks);
>     }
>
> [3]
>     @Override
>     public void startup(ZooKeeperServer zks) throws IOException,
>             InterruptedException {
>         start();
>         setZooKeeperServer(zks);
>         zks.startdata();
>         zks.startup();
>     }
>
> [4]
>     @Override
>     public void startup(ZooKeeperServer zks) throws IOException,
>             InterruptedException {
>         start();
>         zks.startdata();
>         setZooKeeperServer(zks);
>         zks.startup();
>     }
>

--001a11c348f0b12d690502100472--