Return-Path: X-Original-To: apmail-zookeeper-user-archive@www.apache.org Delivered-To: apmail-zookeeper-user-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00ED9104E5 for ; Tue, 10 Sep 2013 21:00:05 +0000 (UTC) Received: (qmail 14307 invoked by uid 500); 10 Sep 2013 21:00:04 -0000 Delivered-To: apmail-zookeeper-user-archive@zookeeper.apache.org Received: (qmail 14200 invoked by uid 500); 10 Sep 2013 21:00:04 -0000 Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@zookeeper.apache.org Delivered-To: mailing list user@zookeeper.apache.org Received: (qmail 14192 invoked by uid 99); 10 Sep 2013 21:00:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Sep 2013 21:00:04 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of ted.dunning@gmail.com designates 209.85.223.180 as permitted sender) Received: from [209.85.223.180] (HELO mail-ie0-f180.google.com) (209.85.223.180) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Sep 2013 20:59:59 +0000 Received: by mail-ie0-f180.google.com with SMTP id 10so13728282ied.25 for ; Tue, 10 Sep 2013 13:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=ILhdVncSUu3ix2CJIDEEcjzhQxY1yZTjOOA0lnqzODg=; b=MfKU4pdfHrXTES4qIh5UH+xJytJcumtqv2MNUDc++KOFC2Kmv91ukqQIx0HdipR6Ya TpdGpriE+Nq2V9mBTbSG1E2t8Lzucl+b8fDOOCsBeWEjVStE/bd52xw/ElebXY8xV+4w FpUe92ya1rYy7fQorhZLprLxKm/7PglV+FQgYJ5wffw4YjqAbQiWOPubAkR+R2WGAFwL FlzIWTrM5ZSJe0PRQOv9xt/vktaWOg/0Ko+7LWe7eoRUVlzwQfsR3ttLHC7E5IexVEPu q6omNt8oPlsi2lvUaSAV88Lmmc42CQDAxA+E+Sh2MwSjWv/cU3pR88ARsm72a3diEbOG Xetg== X-Received: by 10.50.178.234 with SMTP id db10mr11239436igc.35.1378846778901; Tue, 10 Sep 2013 13:59:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.224.145 with HTTP; Tue, 10 Sep 2013 13:59:08 -0700 (PDT) In-Reply-To: <522F8264.5090606@nicira.com> References: <522F7A9D.20800@nicira.com> <522F8264.5090606@nicira.com> From: Ted Dunning Date: Tue, 10 Sep 2013 13:59:08 -0700 Message-ID: Subject: Re: adding a separate thread to detect network timeouts faster To: Jeremy Stribling Cc: "user@zookeeper.apache.org" Content-Type: multipart/alternative; boundary=089e015387f074cb0104e60dc875 X-Virus-Checked: Checked by ClamAV on apache.org --089e015387f074cb0104e60dc875 Content-Type: text/plain; charset=UTF-8 Since you are talking about client connection failure detection, no, I don't think that there is a major barrier other than actually implementing a reliable check. Keep in mind the cost. There are ZK installs with 100,000 clients. If these are heartbeating every 2 seconds, you have 50,000 packets per second hitting the quorum or 10,000 per server if all connections are well balanced. If you only have 10 clients, the network burden is nominal. On Tue, Sep 10, 2013 at 1:34 PM, Jeremy Stribling wrote: > I mostly agree, but let's assume that a ~5x speedup in detecting those > types of failures is considered significant for some people. Are there > technical reasons that would prevent this idea from working? > > On 09/10/2013 01:31 PM, Ted Dunning wrote: > >> I don't see the strong value here. A few failures would be detected more >> quickly, but I am not convinced that this would actually improve >> functionality significantly. >> >> >> On Tue, Sep 10, 2013 at 1:01 PM, Jeremy Stribling >> wrote: >> >> Hi all, >>> >>> Let's assume that you wanted to deploy ZK in a virtualized environment, >>> despite all of the known drawbacks. Assume we could deploy it such that >>> the ZK servers were all using independent CPUs and storage (though not >>> dedicated disks). Obviously, the shared disks (shared with other, non-ZK >>> VMs on the same hypervisor) will cause ZK to hit the default session >>> timeout occasionally, so you would need to raise the existing session >>> timeout to something like 30 seconds. >>> >>> I'm curious if there would be any technical drawbacks to adding an >>> additional heartbeat mechanism between the clients and the servers, which >>> would have the goal of detecting network-only failures faster than the >>> existing heartbeat mechanism. The idea is that there would be a new >>> thread >>> dedicated to processing these heartbeats, which would not get blocked on >>> I/O. Then the clients could configure a second, smaller timeout value, >>> and >>> it would be assumed that any such timeout indicated a real problem. The >>> existing mechanism would still be in place to catch I/O-related errors. >>> >>> I understand the philosophy that there should be some heartbeat mechanism >>> that takes the disk into account, but I'm having trouble coming up with >>> technical reasons not to add a second mechanism. Obviously, the advantage >>> would be that the clients could detect network failures and system >>> crashes >>> more quickly in an environment with slow disks, and fail over to other >>> servers more quickly. The only disadvantages I can come up with are: >>> >>> 1) More code complexity, and slightly more heartbeat traffic on the wire >>> 2) I think the servers have to log session expirations to disk, so if the >>> sessions expire at a faster rate than the disk can handle, it might lead >>> to >>> a large backlog. >>> >>> Are there other drawbacks I am missing? Would a patch that added >>> something like this be considered, or is it dead from the start? Thanks, >>> >>> Jeremy >>> >>> >>> > --089e015387f074cb0104e60dc875--