Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@zookeeper.apache.org
MIME-Version: 1.0
In-Reply-To: <BANLkTimR4+2SvU4GzPDk8h=feBJ+YLfuBQ@mail.gmail.com>
References: <BANLkTimR4+2SvU4GzPDk8h=feBJ+YLfuBQ@mail.gmail.com>
Date: Fri, 20 May 2011 10:01:10 -0700
Message-ID: <BANLkTikuv1-av_sGg0+wJ1i2icejsj1Uyw@mail.gmail.com>
Subject: Re: compiling c client on solaris/sparc
From: Patrick Hunt <phunt@apache.org>
To: user@zookeeper.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Hi Botond, looking at the history for those lines it looks like that
code has been untouched since before we moved to Apache (2008).

A quick search turned up this interesting backgrounder:
http://www.memoryhole.net/kyle/2007/05/atomic_incrementing.html
(be sure to checkout the comments on that post)

If you'd like to submit a patch to move away from asm I don't see why
we wouldn't consider it. My concern would be that we replace it with
something that we have a high confidence will work on all platforms,
compilers, and compiler versions. Perhaps do it initially as a ifdef?

Patrick

On Fri, May 20, 2011 at 8:06 AM, Botond Hejj
<Botond.Hejj@morganstanley.com> wrote:
> Hi,
>
> I am compiling the zookeeper c client on solaris and I noticed that
> mt_adaptor.c has some assembly code in it. This makes porting to other
> platforms (sparc) difficult. What is the reason behind using assembly and
> are there any plans to change that to c code?
>
> Regards,
> Botond Hejj
> Morgan Stanley | Technology
> Lechner Odon fasor 8 | Floor 07
> Budapest, 1095
> Phone: +36 1 881-3962
> Botond.Hejj@MorganStanley.com
>