zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From h...@apache.org
Subject [zookeeper] branch master updated: ZOOKEEPER-3798: remove the useless code in the ProposalRequestProcessor#processRequest
Date Thu, 01 Oct 2020 04:40:03 GMT
This is an automated email from the ASF dual-hosted git repository.

hanm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 4959060  ZOOKEEPER-3798: remove the useless code in the ProposalRequestProcessor#processRequest
4959060 is described below

commit 495906063078a477e26f4e99e14dfe8f89007625
Author: Nishanth Entoor <entoor.nishanth@gmail.com>
AuthorDate: Wed Sep 30 21:39:51 2020 -0700

    ZOOKEEPER-3798: remove the useless code in the ProposalRequestProcessor#processRequest
    
    As per [ZOOKEEPER-3798](https://issues.apache.org/jira/browse/ZOOKEEPER-3798), I removed
the unwanted commented code.
    
    Author: Nishanth Entoor <entoor.nishanth@gmail.com>
    
    Reviewers: hanm, maoling, TisonKun, ravowlga123
    
    Closes #1335 from nishanth-entoor/ZOOKEEPER-3798
---
 .../apache/zookeeper/server/quorum/ProposalRequestProcessor.java    | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
index a3f1b29..c1e2fe1 100644
--- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
+++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
@@ -66,11 +66,6 @@ public class ProposalRequestProcessor implements RequestProcessor {
     }
 
     public void processRequest(Request request) throws RequestProcessorException {
-        // LOG.warn("Ack>>> cxid = " + request.cxid + " type = " +
-        // request.type + " id = " + request.sessionId);
-        // request.addRQRec(">prop");
-
-
         /* In the following IF-THEN-ELSE block, we process syncs on the leader.
          * If the sync is coming from a follower, then the follower
          * handler adds it to syncHandler. Otherwise, if it is a client of
@@ -78,7 +73,6 @@ public class ProposalRequestProcessor implements RequestProcessor {
          * contain the handler. In this case, we add it to syncHandler, and
          * call processRequest on the next processor.
          */
-
         if (request instanceof LearnerSyncRequest) {
             zks.getLeader().processSync((LearnerSyncRequest) request);
         } else {


Mime
View raw message