zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fang...@apache.org
Subject [zookeeper] branch master updated: ZOOKEEPER-3805: NIOServerCnxnFactory static block has no used code
Date Thu, 07 May 2020 21:55:07 GMT
This is an automated email from the ASF dual-hosted git repository.

fangmin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new ae7f72d  ZOOKEEPER-3805: NIOServerCnxnFactory static block has no used code
ae7f72d is described below

commit ae7f72d31e4dc9c6e307b1c14271e74950b022dc
Author: javhu <13621135641@163.com>
AuthorDate: Thu May 7 14:54:59 2020 -0700

    ZOOKEEPER-3805: NIOServerCnxnFactory static block has no used code
    
    the jvm bug: JDK-6427854 : (se) NullPointerException in Selector.open()
    has been fixed in JDK7 b08
    
    Author: javhu <13621135641@163.com>
    
    Reviewers: ctubbsii@apache.org, symat@apache.org, eolivelli@apache.org, fangmin@apache.org
    
    Closes #1338 from Javhu/ZOOKEEPER-3805
---
 .../java/org/apache/zookeeper/server/NIOServerCnxnFactory.java | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
index de29fa2..558b93b 100644
--- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
+++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
@@ -87,16 +87,6 @@ public class NIOServerCnxnFactory extends ServerCnxnFactory {
                 LOG.error("Thread {} died", t, e);
             }
         });
-        /**
-         * this is to avoid the jvm bug:
-         * NullPointerException in Selector.open()
-         * http://bugs.sun.com/view_bug.do?bug_id=6427854
-         */
-        try {
-            Selector.open().close();
-        } catch (IOException ie) {
-            LOG.error("Selector failed to open", ie);
-        }
 
         /**
          * Value of 0 disables use of direct buffers and instead uses


Mime
View raw message