zookeeper-commits mailing list archives

This is an automated email from the ASF dual-hosted git repository.

hanm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 4de5f01  ZOOKEEPER-3494: remove unnecessary broad netty-all dependency
4de5f01 is described below

commit 4de5f012a56e26d72bcddf782995849d7a9e7cfd
Author: Norbert Kalmar <nkalmar@yahoo.com>
AuthorDate: Mon Aug 5 16:55:55 2019 -0700

    ZOOKEEPER-3494: remove unnecessary broad netty-all dependency
    
    Currently netty-all is a 4MB dependency.
    Using netty-handler (429KB) and netty-transport-native-epoll (115KB) brings it down to
about 1/8 in size.
    
    Author: Norbert Kalmar <nkalmar@yahoo.com>
    
    Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Tamás Pénzes, Michael Han <hanm@apache.org>
    
    Closes #1039 from nkalmar/ZK-3494
---
 ivy.xml                  | 7 +++++--
 pom.xml                  | 7 ++++++-
 zookeeper-server/pom.xml | 6 +++++-
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/ivy.xml b/ivy.xml
index c373bb5..3797845 100644
--- a/ivy.xml
+++ b/ivy.xml
@@ -60,8 +60,11 @@
     <dependency org="org.apache.yetus" name="audience-annotations"
                 rev="${audience-annotations.version}"/>
 
-    <dependency org="io.netty" name="netty-all" conf="default" rev="${netty.version}">
-      <artifact name="netty-all" type="jar" conf="default"/>
+    <dependency org="io.netty" name="netty-handler" conf="default" rev="${netty.version}">
+      <artifact name="netty-handler" type="jar" conf="default"/>
+    </dependency>
+    <dependency org="io.netty" name="netty-transport-native-epoll" conf="default" rev="${netty.version}">
+      <artifact name="netty-transport-native-epoll" type="jar" conf="default"/>
     </dependency>
 
     <dependency org="com.googlecode.json-simple" name="json-simple" rev="${json.version}"
>
diff --git a/pom.xml b/pom.xml
index 718a7d5..cb08522 100755
--- a/pom.xml
+++ b/pom.xml
@@ -400,7 +400,12 @@
       </dependency>
       <dependency>
         <groupId>io.netty</groupId>
-        <artifactId>netty-all</artifactId>
+        <artifactId>netty-handler</artifactId>
+        <version>${netty.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-transport-native-epoll</artifactId>
         <version>${netty.version}</version>
       </dependency>
       <dependency>
diff --git a/zookeeper-server/pom.xml b/zookeeper-server/pom.xml
index 125600c..307e650 100755
--- a/zookeeper-server/pom.xml
+++ b/zookeeper-server/pom.xml
@@ -70,7 +70,11 @@
     </dependency>
     <dependency>
       <groupId>io.netty</groupId>
-      <artifactId>netty-all</artifactId>
+      <artifactId>netty-handler</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>io.netty</groupId>
+      <artifactId>netty-transport-native-epoll</artifactId>
     </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>