Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 83B1B200C39 for ; Thu, 16 Mar 2017 11:35:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 82598160B8E; Thu, 16 Mar 2017 10:35:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CD381160B78 for ; Thu, 16 Mar 2017 11:35:49 +0100 (CET) Received: (qmail 6897 invoked by uid 500); 16 Mar 2017 10:35:47 -0000 Mailing-List: contact commits-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list commits@zookeeper.apache.org Received: (qmail 6774 invoked by uid 99); 16 Mar 2017 10:35:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Mar 2017 10:35:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 15B1DDFE7B; Thu, 16 Mar 2017 10:35:47 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: rakeshr@apache.org To: commits@zookeeper.apache.org Message-Id: <769f46df422e4cfa80d7706bbed9abd9@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: zookeeper git commit: ZOOKEEPER-2716: Flaky Test: org.apache.zookeeper.server.SessionTrackerTest.testAddSessionAfterSessionExpiry Date: Thu, 16 Mar 2017 10:35:47 +0000 (UTC) archived-at: Thu, 16 Mar 2017 10:35:50 -0000 Repository: zookeeper Updated Branches: refs/heads/branch-3.4 1b59e3cde -> 3e5000f5f ZOOKEEPER-2716: Flaky Test: org.apache.zookeeper.server.SessionTrackerTest.testAddSessionAfterSessionExpiry We can't let the gate open until we increase the closed session count. Otherwise depends on timing, the test thread might see old session close count value between gate open and the session count actually gets increased. Author: Michael Han Reviewers: Abraham Fine , Rakesh Radhakrishnan Closes #187 from hanm/ZOOKEEPER-2716 (cherry picked from commit 86438f9c6e65b2a95d709bf575cdcc2abc1c2e8b) Signed-off-by: Rakesh Radhakrishnan Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/3e5000f5 Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/3e5000f5 Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/3e5000f5 Branch: refs/heads/branch-3.4 Commit: 3e5000f5f5b30b838db709fa95228e556612eacf Parents: 1b59e3c Author: Michael Han Authored: Thu Mar 16 21:43:45 2017 +0530 Committer: Rakesh Radhakrishnan Committed: Thu Mar 16 21:46:26 2017 +0530 ---------------------------------------------------------------------- src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zookeeper/blob/3e5000f5/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java ---------------------------------------------------------------------- diff --git a/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java b/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java index 61072e6..f427102 100644 --- a/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java +++ b/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java @@ -143,8 +143,8 @@ public class SessionTrackerTest extends ZKTestCase { public void processRequest(Request request) { // check session close request if (request.type == OpCode.closeSession) { - latch.countDown(); countOfCloseSessionReq++; + latch.countDown(); } }