zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rake...@apache.org
Subject zookeeper git commit: ZOOKEEPER-2716: Flaky Test: org.apache.zookeeper.server.SessionTrackerTest.testAddSessionAfterSessionExpiry
Date Thu, 16 Mar 2017 10:33:05 GMT
Repository: zookeeper
Updated Branches:
  refs/heads/master 6949af062 -> 86438f9c6


ZOOKEEPER-2716: Flaky Test: org.apache.zookeeper.server.SessionTrackerTest.testAddSessionAfterSessionExpiry

We can't let the gate open until we increase the closed session count. Otherwise depends on
timing, the test thread might see old session close count value between gate open and the
session count actually gets increased.

Author: Michael Han <hanm@apache.org>

Reviewers: Abraham Fine <afine@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org>

Closes #187 from hanm/ZOOKEEPER-2716


Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/86438f9c
Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/86438f9c
Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/86438f9c

Branch: refs/heads/master
Commit: 86438f9c6e65b2a95d709bf575cdcc2abc1c2e8b
Parents: 6949af0
Author: Michael Han <hanm@apache.org>
Authored: Thu Mar 16 21:43:45 2017 +0530
Committer: Rakesh Radhakrishnan <rakeshr@apache.org>
Committed: Thu Mar 16 21:43:45 2017 +0530

----------------------------------------------------------------------
 src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zookeeper/blob/86438f9c/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java
----------------------------------------------------------------------
diff --git a/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java b/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java
index 87aa73e..00e34fa 100644
--- a/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java
+++ b/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java
@@ -143,8 +143,8 @@ public class SessionTrackerTest extends ZKTestCase {
         public void processRequest(Request request) {
             // check session close request
             if (request.type == OpCode.closeSession) {
-                latch.countDown();
                 countOfCloseSessionReq++;
+                latch.countDown();
             }
         }
 


Mime
View raw message