zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From si...@apache.org
Subject svn commit: r1565105 - in /zookeeper/bookkeeper/trunk: CHANGES.txt bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
Date Thu, 06 Feb 2014 08:21:08 GMT
Author: sijie
Date: Thu Feb  6 08:21:08 2014
New Revision: 1565105

URL: http://svn.apache.org/r1565105
Log:
BOOKKEEPER-728: Bookkeeper#Builder is not public, so can't be used outside of client package
(ivank via fpj)

Modified:
    zookeeper/bookkeeper/trunk/CHANGES.txt
    zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java

Modified: zookeeper/bookkeeper/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/CHANGES.txt?rev=1565105&r1=1565104&r2=1565105&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/CHANGES.txt (original)
+++ zookeeper/bookkeeper/trunk/CHANGES.txt Thu Feb  6 08:21:08 2014
@@ -156,6 +156,8 @@ Trunk (unreleased changes)
 
         BOOKKEEPER-727: Names of bookie write/read threads are backwards (ivank via fpj)
 
+        BOOKKEEPER-728: Bookkeeper#Builder is not public, so can't be used outside of client
package (ivank via fpj)
+
       hedwig-server:
 
         BOOKKEEPER-601: readahead cache size isn't updated correctly (sijie via fpj)

Modified: zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java?rev=1565105&r1=1565104&r2=1565105&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
(original)
+++ zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
Thu Feb  6 08:21:08 2014
@@ -110,7 +110,7 @@ public class BookKeeper {
         public void connectionFailed(int code);
     }
 
-    static class Builder {
+    public static class Builder {
         final ClientConfiguration conf;
 
         ZooKeeper zk = null;
@@ -121,22 +121,22 @@ public class BookKeeper {
             this.conf = conf;
         }
 
-        Builder setChannelFactory(ClientSocketChannelFactory f) {
+        public Builder setChannelFactory(ClientSocketChannelFactory f) {
             channelFactory = f;
             return this;
         }
 
-        Builder setZookeeper(ZooKeeper zk) {
+        public Builder setZookeeper(ZooKeeper zk) {
             this.zk = zk;
             return this;
         }
 
-        Builder setStatsLogger(StatsLogger statsLogger) {
+        public Builder setStatsLogger(StatsLogger statsLogger) {
             this.statsLogger = statsLogger;
             return this;
         }
 
-        BookKeeper build() throws IOException, InterruptedException, KeeperException {
+        public BookKeeper build() throws IOException, InterruptedException, KeeperException
{
             boolean ownZK = false;
             boolean ownChannelFactory = false;
             if (zk == null) {



Mime
View raw message