From notifications-return-8049-archive-asf-public=cust-asf.ponee.io@yetus.apache.org Wed Oct 30 18:43:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4D088180654 for ; Wed, 30 Oct 2019 19:43:02 +0100 (CET) Received: (qmail 91762 invoked by uid 500); 30 Oct 2019 18:43:01 -0000 Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yetus.apache.org Delivered-To: mailing list notifications@yetus.apache.org Received: (qmail 91751 invoked by uid 99); 30 Oct 2019 18:43:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Oct 2019 18:43:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DFB8BE0708 for ; Wed, 30 Oct 2019 18:43:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 55E3178027D for ; Wed, 30 Oct 2019 18:43:00 +0000 (UTC) Date: Wed, 30 Oct 2019 18:43:00 +0000 (UTC) From: "Nick Dimiduk (Jira)" To: notifications@yetus.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (YETUS-922) Precommit qualitative checks vote be -0 on overall improvement MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Nick Dimiduk created YETUS-922: ---------------------------------- Summary: Precommit qualitative checks vote be -0 on overall improvement Key: YETUS-922 URL: https://issues.apache.org/jira/browse/YETUS-922 Project: Yetus Issue Type: Improvement Components: Precommit Reporter: Nick Dimiduk Looking at the output over on [hbase/775|https://github.com/apache/hbase/pull/775#issuecomment-547725241], I think the -1 votes on qualitative checks are a bit harsh. The tests I'm looking at are {{javac}} and {checkstyle}}, where we have a qualitative measure of change in quality. In this case, the patch improved quality by reducing the overall number of failure occurrences. I think these should be voted as -0 rather than -1. I suspect the reasoning behind the -1 vote is that the patch is viewed to have introduced new failures. The thing is, with patches that refactor code, this simple diff isn't able to distinguish between an actual new failure and a moved failure. I could also argue that they should actually be +1 when {{total}} is less than {{previous}} because it's positive trajectory for the code base. {noformat} javac | hbase-server generated 1 new + 3 unchanged - 3 fixed = 4 total (was 6) checkstyle | hbase-server: The patch generated 12 new + 270 unchanged - 37 fixed = 282 total (was 307) {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)