From notifications-return-8033-archive-asf-public=cust-asf.ponee.io@yetus.apache.org Tue Oct 15 17:09:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3DCC918067C for ; Tue, 15 Oct 2019 19:09:05 +0200 (CEST) Received: (qmail 43830 invoked by uid 500); 15 Oct 2019 17:09:03 -0000 Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yetus.apache.org Delivered-To: mailing list notifications@yetus.apache.org Received: (qmail 43734 invoked by uid 99); 15 Oct 2019 17:09:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Oct 2019 17:09:03 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 09A34E30A4 for ; Tue, 15 Oct 2019 17:09:03 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 94CBD780A00 for ; Tue, 15 Oct 2019 17:09:00 +0000 (UTC) Date: Tue, 15 Oct 2019 17:09:00 +0000 (UTC) From: "Yetus QA (Jira)" To: notifications@yetus.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YETUS-919) Support extra Docker build-args MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YETUS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952125#comment-16952125 ] Yetus QA commented on YETUS-919: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} docker {color} | {color:red} 0m 2s{color} | {color:red} Docker failed to build yetus/yetus:b067f8ec. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | YETUS-919 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12983083/0002-YETUS-919.-Support-extra-Docker-build-args.patch | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/1054/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. > Support extra Docker build-args > ------------------------------- > > Key: YETUS-919 > URL: https://issues.apache.org/jira/browse/YETUS-919 > Project: Yetus > Issue Type: Improvement > Components: Precommit > Reporter: Clay B. > Priority: Minor > Attachments: 0001-YETUS-919.-Support-extra-Docker-build-args.patch, 0002-YETUS-919.-Support-extra-Docker-build-args.patch > > > Trying to use [{{build-arg}}|https://docs.docker.com/engine/reference/commandline/build/#set-build-time-variables---build-arg] options for a build, it seems there is no way to supply build-args to either the [first|https://github.com/apache/yetus/blob/601c145a024f81aed189c319673b2e1c8a3d9e7e/precommit/src/main/shell/core.d/docker.sh#L699-L712] nor [second|https://github.com/apache/yetus/blob/601c145a024f81aed189c319673b2e1c8a3d9e7e/precommit/src/main/shell/core.d/docker.sh#L699-L712] {{docker build}} runs. > This is useful to bake an image with some configuration. I was trying to use {{build-arg}}s to ensure a Docker and Vagrant run could share configuration via shell environment variables. -- This message was sent by Atlassian Jira (v8.3.4#803005)