From notifications-return-8029-archive-asf-public=cust-asf.ponee.io@yetus.apache.org Tue Oct 15 02:21:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AB78B18067C for ; Tue, 15 Oct 2019 04:21:02 +0200 (CEST) Received: (qmail 8163 invoked by uid 500); 15 Oct 2019 02:21:02 -0000 Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yetus.apache.org Delivered-To: mailing list notifications@yetus.apache.org Received: (qmail 8089 invoked by uid 99); 15 Oct 2019 02:21:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Oct 2019 02:21:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B7705E2E39 for ; Tue, 15 Oct 2019 02:21:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 16BD87803CA for ; Tue, 15 Oct 2019 02:21:00 +0000 (UTC) Date: Tue, 15 Oct 2019 02:21:00 +0000 (UTC) From: "Yetus QA (Jira)" To: notifications@yetus.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YETUS-919) Support extra Docker build-args MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YETUS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951487#comment-16951487 ] Yetus QA commented on YETUS-919: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || || || || || {color:brown} Patch Compile Tests {color} || | {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 2s{color} | {color:red} The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 0s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | || || || || {color:brown} Other Tests {color} || | {color:blue}0{color} | {color:blue} asflicense {color} | {color:blue} 0m 17s{color} | {color:blue} ASF License check generated no output? {color} | | {color:black}{color} | {color:black} {color} | {color:black} 2m 59s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/PreCommit-YETUS-Build/1053/artifact/patchprocess/Dockerfile | | JIRA Issue | YETUS-919 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12983003/0001-YETUS-919.-Support-extra-Docker-build-args.patch | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux dd299da409fd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | precommit/src/main/shell/personality/yetus.sh | | git revision | master / c6bb11a | | shellcheck | https://builds.apache.org/job/PreCommit-YETUS-Build/1053/artifact/patchprocess/diff-patch-shellcheck.txt | | Max. process+thread count | 8 (vs. ulimit of 1000) | | modules | C: precommit U: precommit | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/1053/console | | versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 | | Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. > Support extra Docker build-args > ------------------------------- > > Key: YETUS-919 > URL: https://issues.apache.org/jira/browse/YETUS-919 > Project: Yetus > Issue Type: Improvement > Components: Precommit > Reporter: Clay B. > Priority: Minor > Attachments: 0001-YETUS-919.-Support-extra-Docker-build-args.patch > > > Trying to use [{{build-arg}}|https://docs.docker.com/engine/reference/commandline/build/#set-build-time-variables---build-arg] options for a build, it seems there is no way to supply build-args to either the [first|https://github.com/apache/yetus/blob/601c145a024f81aed189c319673b2e1c8a3d9e7e/precommit/src/main/shell/core.d/docker.sh#L699-L712] nor [second|https://github.com/apache/yetus/blob/601c145a024f81aed189c319673b2e1c8a3d9e7e/precommit/src/main/shell/core.d/docker.sh#L699-L712] {{docker build}} runs. > This is useful to bake an image with some configuration. I was trying to use {{build-arg}}s to ensure a Docker and Vagrant run could share configuration via shell environment variables. -- This message was sent by Atlassian Jira (v8.3.4#803005)