yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yetus QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-919) Support extra Docker build-args
Date Tue, 15 Oct 2019 02:21:00 GMT

    [ https://issues.apache.org/jira/browse/YETUS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951487#comment-16951487
] 

Yetus QA commented on YETUS-919:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 13s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  0s{color} |
{color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red}  0m  2s{color} | {color:red}
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green}  0m  0s{color}
| {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:blue}0{color} | {color:blue} asflicense {color} | {color:blue}  0m 17s{color} | {color:blue}
ASF License check generated no output? {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 59s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/PreCommit-YETUS-Build/1053/artifact/patchprocess/Dockerfile
|
| JIRA Issue | YETUS-919 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12983003/0001-YETUS-919.-Support-extra-Docker-build-args.patch
|
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux dd299da409fd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / c6bb11a |
| shellcheck | https://builds.apache.org/job/PreCommit-YETUS-Build/1053/artifact/patchprocess/diff-patch-shellcheck.txt
|
| Max. process+thread count | 8 (vs. ulimit of 1000) |
| modules | C: precommit U: precommit |
| Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/1053/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 |
| Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |


This message was automatically generated.



> Support extra Docker build-args
> -------------------------------
>
>                 Key: YETUS-919
>                 URL: https://issues.apache.org/jira/browse/YETUS-919
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Precommit
>            Reporter: Clay B.
>            Priority: Minor
>         Attachments: 0001-YETUS-919.-Support-extra-Docker-build-args.patch
>
>
> Trying to use [{{build-arg}}|https://docs.docker.com/engine/reference/commandline/build/#set-build-time-variables---build-arg]
options for a build, it seems there is no way to supply build-args to either the [first|https://github.com/apache/yetus/blob/601c145a024f81aed189c319673b2e1c8a3d9e7e/precommit/src/main/shell/core.d/docker.sh#L699-L712]
nor [second|https://github.com/apache/yetus/blob/601c145a024f81aed189c319673b2e1c8a3d9e7e/precommit/src/main/shell/core.d/docker.sh#L699-L712]
{{docker build}} runs.
> This is useful to bake an image with some configuration. I was trying to use {{build-arg}}s
to ensure a Docker and Vagrant run could share configuration via shell environment variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message