yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yetus QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-771) Dockerfile.patchspecific doesn't work when gid isn't defined
Date Sun, 03 Feb 2019 21:30:00 GMT

    [ https://issues.apache.org/jira/browse/YETUS-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759546#comment-16759546
] 

Yetus QA commented on YETUS-771:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  6m 29s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 13s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 10s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m  9s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} hadolint {color} | {color:green}  0m  2s{color} |
{color:green} There were no new hadolint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m  0s{color}
| {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  8s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m  8s{color} | {color:green}
precommit in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m  9s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  8m 41s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-YETUS-Build/931/artifact/patchprocess/Dockerfile
|
| JIRA Issue | YETUS-771 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12957463/YETUS-771.00.patch
|
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  hadolint  shellcheck  |
| uname | Linux 7620e20c1012 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / bf88009 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| shellcheck | v0.4.6 |
|  Test Results | https://builds.apache.org/job/PreCommit-YETUS-Build/931/testReport/ |
| Max. process+thread count | 98 (vs. ulimit of 1000) |
| modules | C: precommit U: precommit |
| Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/931/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |


This message was automatically generated.



> Dockerfile.patchspecific doesn't work when gid isn't defined
> ------------------------------------------------------------
>
>                 Key: YETUS-771
>                 URL: https://issues.apache.org/jira/browse/YETUS-771
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.9.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Minor
>              Labels: beginner
>             Fix For: 0.10.0
>
>         Attachments: YETUS-771.00.patch
>
>
> If test-patch is run on a node without docker installed, this code
> {code}
> RUN if [ "${DOCKER_SOCKET_GID}" = -1 ]; then groupadd --non-unique --gid ${DOCKER_SOCKET_GID}
dockersock || true; fi
> {code}
> ... won't work.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message