From notifications-return-5489-archive-asf-public=cust-asf.ponee.io@yetus.apache.org Fri Jul 20 23:45:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E2DF3180663 for ; Fri, 20 Jul 2018 23:45:02 +0200 (CEST) Received: (qmail 93567 invoked by uid 500); 20 Jul 2018 21:45:02 -0000 Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yetus.apache.org Delivered-To: mailing list notifications@yetus.apache.org Received: (qmail 93558 invoked by uid 99); 20 Jul 2018 21:45:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jul 2018 21:45:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A0529C852F for ; Fri, 20 Jul 2018 21:45:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.801 X-Spam-Level: X-Spam-Status: No, score=-109.801 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lWmHqZEneThL for ; Fri, 20 Jul 2018 21:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C54EB5F1B7 for ; Fri, 20 Jul 2018 21:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5A3D6E00CC for ; Fri, 20 Jul 2018 21:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1F5562713C for ; Fri, 20 Jul 2018 21:45:00 +0000 (UTC) Date: Fri, 20 Jul 2018 21:45:00 +0000 (UTC) From: "Jack Bearden (JIRA)" To: notifications@yetus.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YETUS-307) upgrade to middleman v4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YETUS-307?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16551= 332#comment-16551332 ]=20 Jack Bearden commented on YETUS-307: ------------------------------------ Hey [~busbey]! I was hacking at this last night and was able to come up wit= h a patch (#01).=20 Quick list of changes: * The way Middleman v4 evaluates paths changed so I needed to fix the two = instances that=C2=A0were not=C2=A0formatted properly anymore. * The after_configuration block is ran twice in v4 =E2=80=93 once for glob= al configuration options and second for normal execution. I added a guard s= o it doesn't build twice. * YAML files from the data folder need an app prefix now. I adjusted those= variables accordingly. * With the v4 update came a bunch of dependency upgrades * Changes do not incur new rubocop offenses I tested this on my local machine and from what I am able to tell, it works= the same as master does.=C2=A0Please review and let me know if there's any= thing I missed. Thanks! > upgrade to middleman v4 > ----------------------- > > Key: YETUS-307 > URL: https://issues.apache.org/jira/browse/YETUS-307 > Project: Yetus > Issue Type: Improvement > Components: website and documentation > Reporter: Sean Busbey > Priority: Major > Attachments: YETUS-307.01.patch > > > Middleman v4+ is out now. It's supposed to add the ability to have multip= le source locations, so we can remove our hacky use of symlinks. > upgrade guide: > https://middlemanapp.com/basics/upgrade-v4/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)