From notifications-return-5560-archive-asf-public=cust-asf.ponee.io@yetus.apache.org Sat Jul 28 00:40:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1327D180657 for ; Sat, 28 Jul 2018 00:40:03 +0200 (CEST) Received: (qmail 38322 invoked by uid 500); 27 Jul 2018 22:40:03 -0000 Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yetus.apache.org Delivered-To: mailing list notifications@yetus.apache.org Received: (qmail 38312 invoked by uid 99); 27 Jul 2018 22:40:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jul 2018 22:40:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B88FFC1B3C for ; Fri, 27 Jul 2018 22:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Uwj-D08ZnzJT for ; Fri, 27 Jul 2018 22:40:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5CE345F107 for ; Fri, 27 Jul 2018 22:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 96535E260A for ; Fri, 27 Jul 2018 22:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1991E27752 for ; Fri, 27 Jul 2018 22:40:00 +0000 (UTC) Date: Fri, 27 Jul 2018 22:40:00 +0000 (UTC) From: "Jack Bearden (JIRA)" To: notifications@yetus.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YETUS-46) releasedocmaker should support JIRA authentication MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YETUS-46?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165604= 28#comment-16560428 ]=20 Jack Bearden commented on YETUS-46: ----------------------------------- I tested this patch and it works as intended, provided=C2=A0both environmen= t variables exist. If one or both are not present however, the function wil= l bomb out with the following error: =C2=A0 {code:java} KeyError: 'RDM_JIRA_USERNAME' or=C2=A0KeyError: 'RDM_JIRA_PASSWORD'.{code} I believe the function you intended to use was os.environ.get() as that wou= ld return null if the key was not present. IE: {code:java} os.environ.get('RDM_JIRA_USERNAME') os.environ.get('RDM_JIRA_PASSWORD'){code} I'd recommend using the get() to access the environment variable otherwise = we may run the risk of breaking existing Yetus installs with=C2=A0Jira requ= ests that do not use authentication and do not have empty values for those = variables.=C2=A0 > releasedocmaker should support JIRA authentication > -------------------------------------------------- > > Key: YETUS-46 > URL: https://issues.apache.org/jira/browse/YETUS-46 > Project: Yetus > Issue Type: New Feature > Components: Release Doc Maker > Affects Versions: 0.2.0 > Reporter: Allen Wittenauer > Assignee: Allen Wittenauer > Priority: Major > Fix For: 0.8.0 > > Attachments: YETUS-46.00.patch, YETUS-46.001.patch, YETUS-46.002.= patch > > > This is needed for non-wide-open JIRA installations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)