From notifications-return-5531-archive-asf-public=cust-asf.ponee.io@yetus.apache.org Thu Jul 26 08:10:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 57775180621 for ; Thu, 26 Jul 2018 08:10:03 +0200 (CEST) Received: (qmail 54684 invoked by uid 500); 26 Jul 2018 06:10:02 -0000 Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yetus.apache.org Delivered-To: mailing list notifications@yetus.apache.org Received: (qmail 54674 invoked by uid 99); 26 Jul 2018 06:10:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jul 2018 06:10:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0D4081806AB for ; Thu, 26 Jul 2018 06:10:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VwlYe-sfYCab for ; Thu, 26 Jul 2018 06:10:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 271285F1C7 for ; Thu, 26 Jul 2018 06:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D95BE25A4 for ; Thu, 26 Jul 2018 06:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B4E127761 for ; Thu, 26 Jul 2018 06:10:00 +0000 (UTC) Date: Thu, 26 Jul 2018 06:10:00 +0000 (UTC) From: "Allen Wittenauer (JIRA)" To: notifications@yetus.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YETUS-14) test-patch should handle module movement MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YETUS-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556947#comment-16556947 ] Allen Wittenauer commented on YETUS-14: --------------------------------------- Just a note that the fine folks over in Lucene Land just hit this issue with a patch that deleted a module (LUCENE-8369). I know earlier (well, years ago haha) I thought this would be harder to fix, but now I'm not so sure. In the case of a deletion, just use the parent module. In the case of a movement, just add both parent modules. Then just unique the module list. This should give proper test coverage since the parent modules should also get tested to make sure they either have removed references to the 'old' one or added references to the 'new' one. [This was probably harder back in the 0.1.0 days because we didn't have quite the library of functions built up for module manipulation. We're in much better shape now.] > test-patch should handle module movement > ---------------------------------------- > > Key: YETUS-14 > URL: https://issues.apache.org/jira/browse/YETUS-14 > Project: Yetus > Issue Type: Bug > Components: Test Patch > Affects Versions: 0.1.0 > Reporter: Sean Busbey > Priority: Major > > test-patch reported a variety of errors against HADOOP-11804 caused by the fact that a module moved -- This message was sent by Atlassian JIRA (v7.6.3#76005)