yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jack Bearden (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-46) releasedocmaker should support JIRA authentication
Date Fri, 27 Jul 2018 22:40:00 GMT

    [ https://issues.apache.org/jira/browse/YETUS-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560428#comment-16560428
] 

Jack Bearden commented on YETUS-46:
-----------------------------------

I tested this patch and it works as intended, provided both environment variables exist.
If one or both are not present however, the function will bomb out with the following error:

 
{code:java}
KeyError: 'RDM_JIRA_USERNAME' or KeyError: 'RDM_JIRA_PASSWORD'.{code}
I believe the function you intended to use was os.environ.get() as that would return null
if the key was not present. IE:
{code:java}
os.environ.get('RDM_JIRA_USERNAME')
os.environ.get('RDM_JIRA_PASSWORD'){code}
I'd recommend using the get() to access the environment variable otherwise we may run the
risk of breaking existing Yetus installs with Jira requests that do not use authentication
and do not have empty values for those variables. 

> releasedocmaker should support JIRA authentication
> --------------------------------------------------
>
>                 Key: YETUS-46
>                 URL: https://issues.apache.org/jira/browse/YETUS-46
>             Project: Yetus
>          Issue Type: New Feature
>          Components: Release Doc Maker
>    Affects Versions: 0.2.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.8.0
>
>         Attachments: YETUS-46.00.patch, YETUS-46.001.patch, YETUS-46.002.patch
>
>
> This is needed for non-wide-open JIRA installations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message