yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-14) test-patch should handle module movement
Date Thu, 26 Jul 2018 06:10:00 GMT

    [ https://issues.apache.org/jira/browse/YETUS-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556947#comment-16556947
] 

Allen Wittenauer commented on YETUS-14:
---------------------------------------

Just a note that the fine folks over in Lucene Land just hit this issue with a patch that
deleted a module (LUCENE-8369).

I know earlier (well, years ago haha) I thought this would be harder to fix, but now I'm not
so sure.  In the case of a deletion, just use the parent module.  In the case of a movement,
just add both parent modules.  Then just unique the module list. This should give proper test
coverage since the parent modules should also get tested to make sure they either have removed
references to the 'old' one or added references to the 'new' one.  [This was probably harder
back in the 0.1.0 days because we didn't have quite the library of functions built up for
module manipulation.  We're in much better shape now.]



> test-patch should handle module movement
> ----------------------------------------
>
>                 Key: YETUS-14
>                 URL: https://issues.apache.org/jira/browse/YETUS-14
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.1.0
>            Reporter: Sean Busbey
>            Priority: Major
>
> test-patch reported a variety of errors against HADOOP-11804 caused by the fact that
a module moved



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message