yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-527) recognize docs patches
Date Fri, 30 Jun 2017 23:25:00 GMT

    [ https://issues.apache.org/jira/browse/YETUS-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070852#comment-16070852
] 

Allen Wittenauer commented on YETUS-527:
----------------------------------------

After thinking about this a bit, I remember why it wasn't implemented like that to begin with:
 we really don't know whether or not these files are being used for input into tests.

Maybe the real fix here is to exempt certain file names (regardless of extension) if they
appear in the root of the tree.  e.g., README, NOTICE, LICENSE, COPYING, BUILDING, NOTES,
ACKNOWLEDGEMENTS, NEWS, AUTHORS, CONTRIBUTINGS, ....

It'll still trigger a failure if one of these appears elsewhere in the tree, but I suspect
this would cut down on at least a good chunk of the false negatives.

> recognize docs patches
> ----------------------
>
>                 Key: YETUS-527
>                 URL: https://issues.apache.org/jira/browse/YETUS-527
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Mike Drob
>
> When somebody posts a doc-only patch, we shouldn't make a red -1 on test4tests over it.
> Maybe detect if all the changed files are {{.adoc}} or {{.md}} or maybe there's some
other type to consider also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message