yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-527) recognize docs patches
Date Fri, 30 Jun 2017 22:07:00 GMT

    [ https://issues.apache.org/jira/browse/YETUS-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070783#comment-16070783
] 

Allen Wittenauer commented on YETUS-527:
----------------------------------------

I think what [~mdrob] is looking for is something along the lines of:

{code}
function test4tests_patchfile
...
  for i in "${CHANGED_FILES[@]}"; do
    if [[ $i =~ \.(md|txt|adoc|html)$ ]]; then
      ((doccount=doccount + 1))
   fi
  done

  if [[ ${doccount) = ${#CHANGED_FILES[@]} ]]; then
    add_vote_table +1 "test4tests" "Patch is only text files. No tests needed."
    return 0
  fi
....
{code}

or something like that.  I'm sure that regex up there is wrong. lol  At a minimum, we probably
need to have some way to define it for some of the more weirdo formats.

> recognize docs patches
> ----------------------
>
>                 Key: YETUS-527
>                 URL: https://issues.apache.org/jira/browse/YETUS-527
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Mike Drob
>
> When somebody posts a doc-only patch, we shouldn't make a red -1 on test4tests over it.
> Maybe detect if all the changed files are {{.adoc}} or {{.md}} or maybe there's some
other type to consider also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message