yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <>
Subject [jira] [Commented] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
Date Thu, 29 Jun 2017 16:38:00 GMT


Allen Wittenauer commented on YETUS-522:

OK, I tested this with HADOOP-11875.  The code hit quite a few edge cases and failed.  The
big one was multiple "assignee" lines in the output, which caused a cascade of errors.


bq. tr ',' '\n' "${PATCH_DIR}/issue"

It looks like only GNU tr takes a file name.  I had to rewrite this to be cat | tr to work
on OS X.  That's clearly a bug in shellcheck and I'll file the appropriate issue against them
here in a sec.

That said: you are definitely making progress on this one!  Keep it up!

> smart-apply-patch should do more to infer author in committer mode
> ------------------------------------------------------------------
>                 Key: YETUS-522
>                 URL:
>             Project: Yetus
>          Issue Type: New Feature
>          Components: Test Patch
>    Affects Versions: 0.1.0
>            Reporter: Sean Busbey
>            Assignee: Akira Ajisaka
>         Attachments: YETUS-522.01.patch, YETUS-522.02.patch, YETUS-522.03.patch, YETUS-522.04.patch,
> In committer mode, we can guess that the user of smart-apply-patch is planning to submit
changes. In the case where the patch wasn't made with format-patch it would be nice to do
some work on behalf of the committer to find an author.
> The obvious case is when the patch is associated with a bug system, we can get the author
from the assignee and set it in a placeholder commit.

This message was sent by Atlassian JIRA

View raw message