Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4620A200C2B for ; Thu, 2 Mar 2017 10:08:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 44A49160B6F; Thu, 2 Mar 2017 09:08:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 89BBC160B61 for ; Thu, 2 Mar 2017 10:08:51 +0100 (CET) Received: (qmail 4872 invoked by uid 500); 2 Mar 2017 09:08:50 -0000 Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yetus.apache.org Delivered-To: mailing list notifications@yetus.apache.org Received: (qmail 4863 invoked by uid 99); 2 Mar 2017 09:08:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 09:08:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3CE2F1A063A for ; Thu, 2 Mar 2017 09:08:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.547 X-Spam-Level: X-Spam-Status: No, score=-1.547 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id F8BLuhbqAjhg for ; Thu, 2 Mar 2017 09:08:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4825E5FE3F for ; Thu, 2 Mar 2017 09:08:48 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E9B4BE08AC for ; Thu, 2 Mar 2017 09:08:46 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A592F24166 for ; Thu, 2 Mar 2017 09:08:45 +0000 (UTC) Date: Thu, 2 Mar 2017 09:08:45 +0000 (UTC) From: "Yetus QA (JIRA)" To: notifications@yetus.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 02 Mar 2017 09:08:52 -0000 [ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891857#comment-15891857 ] Yetus QA commented on YETUS-488: -------------------------------- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/541/console in case of problems. > Checkstyle reports new error if the file still longer than expected > ------------------------------------------------------------------- > > Key: YETUS-488 > URL: https://issues.apache.org/jira/browse/YETUS-488 > Project: Yetus > Issue Type: Improvement > Components: Test Patch > Affects Versions: 0.4.0 > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Minor > Attachments: YETUS-488.00.patch, YETUS-488.01.patch, YETUS-488.02.patch > > > Given a java source file which is originally longer than the checkstyle defined value then we get the following warning every time the length changes and we run the checkstyle plugin: > {code} > ./beeline/src/java/org/apache/hive/beeline/BeeLine.java:1: warning: File length is 2,373 lines (max allowed is 2,000). > {code} > The problem is, that the checkstyle output is changed: > {code:title=From} > ./beeline/src/java/org/apache/hive/beeline/BeeLine.java:1: warning: File length is 2,373 lines (max allowed is 2,000). > {code} > {code:title=To} > ./beeline/src/java/org/apache/hive/beeline/BeeLine.java:1: warning: File length is 2,365 lines (max allowed is 2,000). > {code} > Since the {{checkstyle_calcdiffs}} does not find the new line in the original output, it marks it as a new error, and gives -1 to the result of the checkstyle plugin. > This is true for every error message where there is a number in the text. Not exhaustive examples are below: > - Line length > - Row length > - Function length > - Number of attributes > - Indentation > I think we should be reluctant to give -1 without a reason so it would be good to remove these errors. > I have yet to find the ideal solution for the issue: > - An easy patch could be to remove the numbers from files before the diff (note: it does not effect the final diff-checkstyle-.txt output messages). This would mean that the warning will give -1 only the first time when the error text is occurred, and will not give -1 if the numbers are changed, like > -- File become shorter, but still longer than expected > -- File become even longer > -- Indentation changed but still problematic > - A more sophisticated patch could do this only for specific errors, or even check the value and give error when the line length grow. > To be honest, I think the second solution would complicate the code too much, and make it dependent on the specific checkstyle messages, so I do not like it. > I am even hesitant about the first one, because the change I introducing with it might have unwanted consequences. > Do anyone has better ideas? I would be happy to implement them, if someone points me to the right direction :D > Thanks, > Peter -- This message was sent by Atlassian JIRA (v6.3.15#6346)