Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@yetus.apache.org
Date: Thu, 23 Feb 2017 17:04:44 +0000 (UTC)
From: "Adam Faris (JIRA)" <jira@apache.org>
To: notifications@yetus.apache.org
Message-ID: <JIRA.13005317.1473988721000.45519.1487869484391@Atlassian.JIRA>
In-Reply-To: <JIRA.13005317.1473988721000@Atlassian.JIRA>
References: <JIRA.13005317.1473988721000@Atlassian.JIRA> <JIRA.13005317.1473988721915@jira-lw-us.apache.org>
Subject: [jira] [Updated] (YETUS-460) RDM should handle connection reset by
 peer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 23 Feb 2017 17:04:52 -0000


     [ https://issues.apache.org/jira/browse/YETUS-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Faris updated YETUS-460:
-----------------------------
    Attachment: YETUS-460.07.patch

Thanks and no problems with sticking through-it.  

bq. indentation in the first try-except block in load_jira method is just 1 space instead of the 4

You're right, that style is important.  I updated the spacing to 4 for the try block you mentioned in patch 7.

bq. converting the comments at the beginning of get_jira to docstrings.

Updated in patch 7

bq.  in the interest of saving one more iteration I can amend(and test) the commit 

If there's something I misunderstood and missed, feel free to amend as needed.  

Thanks 

> RDM should handle connection reset by peer
> ------------------------------------------
>
>                 Key: YETUS-460
>                 URL: https://issues.apache.org/jira/browse/YETUS-460
>             Project: Yetus
>          Issue Type: Bug
>          Components: Release Doc Maker
>            Reporter: Allen Wittenauer
>            Assignee: Adam Faris
>             Fix For: 0.5.0
>
>         Attachments: YETUS-460.00.patch, YETUS-460.01.patch, YETUS-460.02.patch, YETUS-460.03.patch, YETUS-460.04.patch, YETUS-460.05.patch, YETUS-460.06.patch, YETUS-460.07.patch
>
>
> When a connection reset by peer error happens, we get a python stack trace.  We should handle that better.
> {code}
> Traceback (most recent call last):
>   File "/Users/aw/shared-vmware/yetus/release-doc-maker/releasedocmaker.py", line 907, in <module>
>     main()
>   File "/Users/aw/shared-vmware/yetus/release-doc-maker/releasedocmaker.py", line 748, in main
>     jlist = sorted(JiraIter(vstr, projects))
>   File "/Users/aw/shared-vmware/yetus/release-doc-maker/releasedocmaker.py", line 400, in __init__
>     self.jiras = JiraIter.collect_jiras(ver, projects)
>   File "/Users/aw/shared-vmware/yetus/release-doc-maker/releasedocmaker.py", line 379, in collect_jiras
>     data = JiraIter.query_jira(ver, projects, pos)
>   File "/Users/aw/shared-vmware/yetus/release-doc-maker/releasedocmaker.py", line 330, in query_jira
>     return JiraIter.load_jira(params, 0)
>   File "/Users/aw/shared-vmware/yetus/release-doc-maker/releasedocmaker.py", line 337, in load_jira
>     params)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 154, in urlopen
>     return opener.open(url, data, timeout)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 429, in open
>     response = self._open(req, data)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 447, in _open
>     '_open', req)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 407, in _call_chain
>     result = func(*args)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1241, in https_open
>     context=self._context)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1201, in do_open
>     r = h.getresponse(buffering=True)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1136, in getresponse
>     response.begin()
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 453, in begin
>     version, status, reason = self._read_status()
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 409, in _read_status
>     line = self.fp.readline(_MAXLINE + 1)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 480, in readline
>     data = self._sock.recv(self._rbufsize)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ssl.py", line 756, in recv
>     return self.read(buflen)
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ssl.py", line 643, in read
>     v = self._sslobj.read(len)
> socket.error: [Errno 54] Connection reset by peer
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)