yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
Date Tue, 28 Feb 2017 17:15:45 GMT

    [ https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888477#comment-15888477
] 

Akira Ajisaka commented on YETUS-489:
-------------------------------------

Thanks [~sekikn] for the review!
bq. Just one question, should we handle other severities such as \[WARN\]? Some project other
than Hadoop may change severity for messages.
Yes. I'm thinking we should handle \[WARN\] as well because a project can change the severity
easily. An example of the setting is https://github.com/checkstyle/checkstyle/blob/checkstyle-7.6/src/test/resources/com/puppycrawl/tools/checkstyle/config-classname.xml#L10
According to https://github.com/checkstyle/checkstyle/blob/checkstyle-7.6/src/main/java/com/puppycrawl/tools/checkstyle/api/SeverityLevel.java,
there are 4 severities in checkstyle:
* IGNORE
* INFO
* WARNING (will become WARN when printed)
* ERROR

and I'll update the patch to handle WARN and ERROR.

> checkstyle.sh does not support checkstyle 6.14 or upper
> -------------------------------------------------------
>
>                 Key: YETUS-489
>                 URL: https://issues.apache.org/jira/browse/YETUS-489
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>         Attachments: YETUS-489.01.patch, YETUS-489.02.patch
>
>
> The output format has changed in checkstyle 6.14 by https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR] /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message