yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Vary (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-484) Fixing bug when checkstyle runs on multiple modules
Date Thu, 02 Feb 2017 14:14:51 GMT

    [ https://issues.apache.org/jira/browse/YETUS-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849952#comment-15849952
] 

Peter Vary commented on YETUS-484:
----------------------------------

Thanks [~aw]!

> Fixing bug when checkstyle runs on multiple modules
> ---------------------------------------------------
>
>                 Key: YETUS-484
>                 URL: https://issues.apache.org/jira/browse/YETUS-484
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.3.0, 0.4.0, 0.5.0
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>             Fix For: 0.5.0
>
>         Attachments: YETUS-484.00.patch
>
>
> When trying to run checkstyle plugin with a patch which changes 2 modules the checkstyle
changes directory to the first modules directory twice, so no change file is generated for
the second directory.
> See:
> {code}
> ============================================================================
> ============================================================================
>                                checkstyle: 
> ============================================================================
> ============================================================================
> [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Start clock
> [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Personality: branch checkstyle
> [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Personality: clear queue
> [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Personality: enqueue ql -DskipTests -Pitests
> [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Personality: enqueue serde -DskipTests -Pitests
> [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Start clock
> cd /Users/petervary/dev/upstream/hive/ql
> mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DskipTests -Pitests -Ptest-patch
> /private/tmp/yetus-16782.23776/maven-branch-checkstyle-ql.txt 2>&1
> [Mon Jan 30 16:20:40 CET 2017 DEBUG]: Stop clock
> [Mon Jan 30 16:20:40 CET 2017 DEBUG]: Start clock
> cd /Users/petervary/dev/upstream/hive/ql
> mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DskipTests -Pitests -Ptest-patch
> /private/tmp/yetus-16782.23776/maven-branch-checkstyle-serde.txt 2>&1
> {code}
> My guess is there is a missing parameter in checkstyle.sh when calling {{   buildtool_cwd}}
without parameters.
> Adding the parameter resolves the directory change problem, and yetus generates the error
report for both modules.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message