Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 12130200B78 for ; Thu, 18 Aug 2016 18:54:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0E3BC160A86; Thu, 18 Aug 2016 16:54:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 85979160AAE for ; Thu, 18 Aug 2016 18:54:21 +0200 (CEST) Received: (qmail 4500 invoked by uid 500); 18 Aug 2016 16:54:20 -0000 Mailing-List: contact notifications-help@yetus.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yetus.apache.org Delivered-To: mailing list notifications@yetus.apache.org Received: (qmail 4481 invoked by uid 99); 18 Aug 2016 16:54:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Aug 2016 16:54:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A41BD2C02A4 for ; Thu, 18 Aug 2016 16:54:20 +0000 (UTC) Date: Thu, 18 Aug 2016 16:54:20 +0000 (UTC) From: "Sean Busbey (JIRA)" To: notifications@yetus.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YETUS-443) github pull request regular expression in the jira plugin should be more complete MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 18 Aug 2016 16:54:22 -0000 [ https://issues.apache.org/jira/browse/YETUS-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated YETUS-443: ------------------------------ Assignee: Casey Brotherton > github pull request regular expression in the jira plugin should be more complete > --------------------------------------------------------------------------------- > > Key: YETUS-443 > URL: https://issues.apache.org/jira/browse/YETUS-443 > Project: Yetus > Issue Type: Bug > Components: Test Patch > Affects Versions: 0.4.0 > Reporter: Casey Brotherton > Assignee: Casey Brotherton > Priority: Minor > > The JIRA plugin ( jira.sh ) uses a regular expression to determine > if there is a github pull request that contains a patch. > There is a duplicate regular expression in github_jira_bridge in > github.sh that is similar, as well as multiple regular expressions > in github_locate_patch that look for slightly different patterns. > The regular expression can wrongly determine that some links are > github pull requests, as it looks for starting with GITHUB_BASE_URL > and just that there are no spaces until the string "patch" > This regular expression should be modified, as well as consideration to whether the regexes should be combined in some way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)