yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yetus QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-430) Refactor releasedocmaker.py in separate modules
Date Tue, 02 Aug 2016 08:44:20 GMT

    [ https://issues.apache.org/jira/browse/YETUS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403633#comment-15403633
] 

Yetus QA commented on YETUS-430:
--------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m  6s{color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green}  0m  7s{color} | {color:green}
The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m  0s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 17s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/yetus:e4e4903 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12821540/YETUS-430.01.patch
|
| JIRA Issue | YETUS-430 |
| Optional Tests |  pylint  |
| uname | Linux 967e367747b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / b110b25 |
| pylint | v1.6.4 |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/467/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Refactor releasedocmaker.py in separate modules
> -----------------------------------------------
>
>                 Key: YETUS-430
>                 URL: https://issues.apache.org/jira/browse/YETUS-430
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Release Doc Maker
>            Reporter: Ajay Yadava
>            Assignee: Ajay Yadava
>         Attachments: YETUS-430.00.patch, YETUS-430.01.patch
>
>
> releasedocmaker.py has reached 993 lines in length. We have set the upper limit on number
of lines in a file to 1000 in .pylintrc.  New additions to the core functionality will make
it trip that line, so I propose to extract utility functions in a separate module. I hope
it will improve readability of the script as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message