yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YETUS-342) non-existent --basedir gives bad error message
Date Tue, 02 Aug 2016 01:40:20 GMT

    [ https://issues.apache.org/jira/browse/YETUS-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403196#comment-15403196
] 

Kengo Seki commented on YETUS-342:
----------------------------------

Thanks for the patch [~clarkkaren], but it seems not to fix the problem.

{code}
sekikn@ubuntu-trusty:~/yetus$ precommit/smart-apply-patch.sh --plugins=all YETUS-342     
           
Processing: YETUS-342
YETUS-342 patch is being downloaded at Tue Aug  2 01:28:46 UTC 2016 from
  https://issues.apache.org/jira/secure/attachment/12821424/YETUS-342.01.patch -> Downloaded
Applying the patch:
Tue Aug  2 01:28:52 UTC 2016
cd /home/sekikn/yetus
git apply --binary -v --stat --apply -p1 /tmp/yetus-10414.21888/patch
Applied patch precommit/test-patch.sh cleanly.
 precommit/test-patch.sh |    5 +++++
 1 file changed, 5 insertions(+)
sekikn@ubuntu-trusty:~/yetus$ test -d /tmp/a                                             
           
sekikn@ubuntu-trusty:~/yetus$ echo $?
1
sekikn@ubuntu-trusty:~/yetus$ precommit/test-patch.sh --basedir=/tmp/a --plugins=all /tmp/p
         
/tmp/yetus-20544.17770 has been created
Modes: 
Processing: /tmp/p
Patch file /tmp/p copied to /tmp/yetus-20544.17770


============================================================================
============================================================================
                        Confirming git environment
============================================================================
============================================================================


ERROR:  is not a valid directory.
{code}

I think we should verify basedir in parse_args.

> non-existent --basedir gives bad error message
> ----------------------------------------------
>
>                 Key: YETUS-342
>                 URL: https://issues.apache.org/jira/browse/YETUS-342
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.2.0
>            Reporter: Allen Wittenauer
>            Assignee: Karen Clark
>         Attachments: YETUS-342.00.patch, YETUS-342.01.patch
>
>
> if the --basedir param points to something that doesn't exist, the error message printed
is bad:
> {code}
> ERROR:  is not a git repo.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message