yetus-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dima Spivak (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YETUS-309) pylint plugin false positives
Date Wed, 17 Aug 2016 17:57:21 GMT

    [ https://issues.apache.org/jira/browse/YETUS-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425035#comment-15425035
] 

Dima Spivak edited comment on YETUS-309 at 8/17/16 5:56 PM:
------------------------------------------------------------

This happened recently over in HBASE-12721 and looks like it would be easy to fix by modifying
[this line of code|https://github.com/apache/yetus/blob/master/precommit/test-patch.d/pylint.sh#L154]
to exclude lines with {{: [I}} (see [this example|https://builds.apache.org/job/PreCommit-HBASE-Build/3111/artifact/patchprocess/patch-pylint-result.txt]).
Can I take this on, [~busbey]?


was (Author: dimaspivak):
This happened recently over in HBASE-12721 and looks like it would be easy to fix by modifying
[this line of code|https://github.com/apache/yetus/blob/master/precommit/test-patch.d/pylint.sh#L153]
to exclude lines with {{: [I}} (see [this example|https://builds.apache.org/job/PreCommit-HBASE-Build/3111/artifact/patchprocess/patch-pylint-result.txt]).
Can I take this on, [~busbey]?

> pylint plugin false positives
> -----------------------------
>
>                 Key: YETUS-309
>                 URL: https://issues.apache.org/jira/browse/YETUS-309
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.1.0
>            Reporter: Sean Busbey
>
> the pylint plugin is flagging some changes as failures when the pylint utility returns
a success return code because of INFO level messages about local disables.
> e.g. in a patch that removes all outstanding issues but has to use local disables in
some cases, test-patch returns a -1 and the diff contains only:
> {code}
> some/path/to/script.py:53: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
> some/path/to/script.py:54: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
> some/path/to/script.py:55: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
> some/path/to/script.py:56: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
> some/path/to/script.py:57: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
> some/path/to/script.py:58: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
> {code}
> In this particular case, the code uses dynamic attributes, which pylint in python 2.x
can't handle. In general, things at the INFO level (IXXXX) shouldn't cause a failure. Or at
a minimum personalities should be able to opt-in to it not failing without overriding the
log output filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message