yetus-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a.@apache.org
Subject [yetus] branch master updated: YETUS-870. remove support for PYLINT_OPTIONS
Date Fri, 03 May 2019 22:50:52 GMT
This is an automated email from the ASF dual-hosted git repository.

aw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yetus.git


The following commit(s) were added to refs/heads/master by this push:
     new d76a93e  YETUS-870. remove support for PYLINT_OPTIONS
d76a93e is described below

commit d76a93e65102c7c40e42c0c28f31a500e9e75b3b
Author: Allen Wittenauer <aw@apache.org>
AuthorDate: Thu May 2 12:01:55 2019 -0700

    YETUS-870. remove support for PYLINT_OPTIONS
    
    Signed-off-by: Sean Busbey <busbey@apache.org>
---
 precommit/src/main/shell/personality/geode.sh   | 3 ---
 precommit/src/main/shell/personality/hadoop.sh  | 2 --
 precommit/src/main/shell/test-patch.d/pylint.sh | 9 ---------
 3 files changed, 14 deletions(-)

diff --git a/precommit/src/main/shell/personality/geode.sh b/precommit/src/main/shell/personality/geode.sh
index 75162cc..e170d56 100755
--- a/precommit/src/main/shell/personality/geode.sh
+++ b/precommit/src/main/shell/personality/geode.sh
@@ -31,7 +31,4 @@ function personality_globals
   GITHUB_REPO_DEFAULT="apache/incubator-geode"
   #shellcheck disable=SC2034
   BUILDTOOL=gradle
-#   PYLINT_OPTIONS="--indent-string='  '"
-
-#   HADOOP_MODULES=""
 }
diff --git a/precommit/src/main/shell/personality/hadoop.sh b/precommit/src/main/shell/personality/hadoop.sh
index 5715c31..6e1a800 100755
--- a/precommit/src/main/shell/personality/hadoop.sh
+++ b/precommit/src/main/shell/personality/hadoop.sh
@@ -35,8 +35,6 @@ function personality_globals
   JIRA_ISSUE_RE='^(HADOOP|YARN|MAPREDUCE|HDFS|HDDS|SUBMARINE)-[0-9]+$'
   #shellcheck disable=SC2034
   GITHUB_REPO_DEFAULT="apache/hadoop"
-  #shellcheck disable=SC2034
-  PYLINT_OPTIONS="--indent-string='  '"
 
   HADOOP_HOMEBREW_DIR=${HADOOP_HOMEBREW_DIR:-$(brew --prefix 2>/dev/null)}
   if [[ -z "${HADOOP_HOMEBREW_DIR}" ]]; then
diff --git a/precommit/src/main/shell/test-patch.d/pylint.sh b/precommit/src/main/shell/test-patch.d/pylint.sh
index d32dd7d..822bf21 100755
--- a/precommit/src/main/shell/test-patch.d/pylint.sh
+++ b/precommit/src/main/shell/test-patch.d/pylint.sh
@@ -22,7 +22,6 @@ PYLINT_TIMER=0
 
 PYLINT=${PYLINT:-$(command -v pylint 2>/dev/null)}
 # backward compatibility, do not use
-PYLINT_OPTIONS=${PYLINT_OPTIONS:-}
 PYLINT_PIP_CMD=$(command -v pip 2>/dev/null)
 PYLINT_REQUIREMENTS=false
 PYLINT_PIP_USER=true
@@ -45,10 +44,6 @@ function pylint_parse_args
     --pylint=*)
       PYLINT=${i#*=}
     ;;
-    --pylint-options=*)
-      # backward compatibility
-      PYLINT_OPTIONS=${i#*=}
-    ;;
     --pylint-pip-cmd=*)
       PYLINT_PIP_CMD=${i#*=}
     ;;
@@ -133,10 +128,6 @@ function pylint_executor
     done
   fi
 
-  # backward compatibility
-  # shellcheck disable=SC2206
-  pylintopts=(${PYLINT_OPTIONS})
-
   if [[ -n "${PYLINT_RCFILE}" ]] && [[ -f "${PYLINT_RCFILE}" ]]; then
     pylintopts+=('--rcfile='"${PYLINT_RCFILE}")
   fi


Mime
View raw message