Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1981A200D0B for ; Wed, 27 Sep 2017 17:57:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 182551609CA; Wed, 27 Sep 2017 15:57:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3606E1609BC for ; Wed, 27 Sep 2017 17:57:05 +0200 (CEST) Received: (qmail 43732 invoked by uid 500); 27 Sep 2017 15:57:04 -0000 Mailing-List: contact dev-help@weex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@weex.incubator.apache.org Delivered-To: mailing list dev@weex.incubator.apache.org Received: (qmail 43721 invoked by uid 99); 27 Sep 2017 15:57:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2017 15:57:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E14C61A466F for ; Wed, 27 Sep 2017 15:57:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id V_61y76z0Dyh for ; Wed, 27 Sep 2017 15:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EB91261116 for ; Wed, 27 Sep 2017 15:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 72E70E061C for ; Wed, 27 Sep 2017 15:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3051F24282 for ; Wed, 27 Sep 2017 15:57:00 +0000 (UTC) Date: Wed, 27 Sep 2017 15:57:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@weex.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WEEX-74) commit-msg in git hook should allow user to submit commit with title [WEEX-xxx] MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 27 Sep 2017 15:57:06 -0000 [ https://issues.apache.org/jira/browse/WEEX-74?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1618277= 3#comment-16182773 ]=20 ASF GitHub Bot commented on WEEX-74: ------------------------------------ GitHub user jondong opened a pull request: https://github.com/apache/incubator-weex/pull/751 [WEEX-74] Added Jira issue number as commit log title As Apache Jira provides the function that can automatically connect commit and Jira issue according to the issue number with specific format, so added a new way in commit message title check regex to allow this. =20 Removed the Merge title because we are not going to allow merge and start to follow the rebase way. =20 Also updated error message to point to the correct URL. =20 First of all, thank you for your contribution!=20 =20 Please makes sure that these checkboxes are checked before submitting y= our PR, thank you! =20 =20 CheckList: =20 **if** *isBugFix* **:** =20 * [ ] Make sure that you add at least one unit test for the bug which= you had fixed. =20 **elif** *isNewFeature* **:** =20 * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. =20 =20 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jondong/incubator-weex WEEX-74 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/751.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #751 =20 ---- commit 634c6413c1e715cb3174b1b039198f339df25736 Author: Jonathan Dong Date: 2017-09-27T15:18:51Z [WEEX-74] Added Jira issue number as commit log title =20 As Apache Jira provides the function that can automatically connect commit and Jira issue according to the issue number with specific format, so added a new way in commit message title check regex to allow this. =20 Removed the Merge title because we are not going to allow merge and start to follow the rebase way. =20 Also updated error message to point to the correct URL. ---- > commit-msg in git hook should allow user to submit commit with title [WEE= X-xxx] > -------------------------------------------------------------------------= ------ > > Key: WEEX-74 > URL: https://issues.apache.org/jira/browse/WEEX-74 > Project: Weex > Issue Type: Improvement > Components: Project=20 > Reporter: Jonathan Dong > Assignee: sospartan > Priority: Minor > > According to the current commit log policy, people can only submit commit= with the title: > {action} [{module}] {description} > more details can be found [here](https://github.com/apache/incubator-weex= /blob/master/CONTRIBUTING.md#commit-log) > As we decided to re-adopt Apache's Jira to track project's bugs and featu= res, we hope we can use the auto-correlation feature to automatically conne= ct commit with Jira issue by setting your commit log title with "[WEEX-xxx]= ". So it is needed to change the commit-msg git hook. -- This message was sent by Atlassian JIRA (v6.4.14#64029)