weex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WEEX-74) commit-msg in git hook should allow user to submit commit with title [WEEX-xxx]
Date Thu, 28 Sep 2017 07:42:00 GMT

    [ https://issues.apache.org/jira/browse/WEEX-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183802#comment-16183802
] 

ASF GitHub Bot commented on WEEX-74:
------------------------------------

Github user gurisxie commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/751#discussion_r141535771
  
    --- Diff: scripts/commit-msg.sh ---
    @@ -17,11 +17,11 @@
     # under the License.
     
     # Validate commit log
    -commit_regex='^Merge.+|[+*-] \[(android|ios|jsfm|html5|component|doc|build|website|example|test|all)\]
.{1,50}'
    +commit_regex='[+*-] \[(android|ios|jsfm|html5|component|doc|build|website|example|test|all)\]
.{1,50}|\[WEEX-[0-9]*\] .{1,50}'
    --- End diff --
    
    @cxfeng1 please make a review


> commit-msg in git hook should allow user to submit commit with title [WEEX-xxx]
> -------------------------------------------------------------------------------
>
>                 Key: WEEX-74
>                 URL: https://issues.apache.org/jira/browse/WEEX-74
>             Project: Weex
>          Issue Type: Improvement
>          Components: Project 
>            Reporter: Jonathan Dong
>            Assignee: sospartan
>            Priority: Minor
>
> According to the current commit log policy, people can only submit commit with the title:
> {action} [{module}] {description}
> more details can be found [here](https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#commit-log)
> As we decided to re-adopt Apache's Jira to track project's bugs and features, we hope
we can use the auto-correlation feature to automatically connect commit with Jira issue by
setting your commit log title with "[WEEX-xxx] <commit title>". So it is needed to change
the commit-msg git hook.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message