weex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WEEX-74) commit-msg in git hook should allow user to submit commit with title [WEEX-xxx]
Date Wed, 27 Sep 2017 15:57:00 GMT

    [ https://issues.apache.org/jira/browse/WEEX-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182773#comment-16182773
] 

ASF GitHub Bot commented on WEEX-74:
------------------------------------

GitHub user jondong opened a pull request:

    https://github.com/apache/incubator-weex/pull/751

    [WEEX-74] Added Jira issue number as commit log title

    As Apache Jira provides the function that can automatically connect
    commit and Jira issue according to the issue number with specific
    format, so added a new way in commit message title check regex to
    allow this.
    
    Removed the Merge title because we are not going to allow merge
    and start to follow the rebase way.
    
    Also updated error message to point to the correct URL.
    
    First of all, thank you for your contribution! 
    
    Please makes sure that these checkboxes are checked before submitting your PR, thank you!
    
    <!-- 
    How to use github markdown?
    ### checkable example
    - [x] checked
    - [ ] not checked
    More github Markdown info to see https://guides.github.com/features/mastering-markdown/
    -->
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [ ] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.
    
    <!--
    (请在***提交***前删除这段描述)
    
    Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
    
    Our new GitHub repo is https://github.com/apache/incubator-weex
    
    After Feb 24 2017, we only accept pull requests from https://github.com/apache/incubator-weex
    
    Thank you for your support.
    
    ----
    
    注意:Weex 将于 2017-02-24 迁移至 Apache 基金会
    
    届时我们会使用新的 GitHub 仓库:https://github.com/apache/incubator-weex 并在那里继续接受大家的
pull request。
    
    更多详情请关注:https://github.com/weexteam/article/issues/130
    
    感谢理解和支持
    
    -->
    
    <!--
    (请在***提交***前删除这段描述)
    It's ***RECOMMENDED*** to submit typo fix, new demo and tiny bugfix to `master` branch.
New feature and other modifications can be submitted to "domain" branch including `ios`, `android`,
`jsfm`, `html5`.
        
    See [Branch Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)
for more detail.
    
    ----
    
    错别字修改、新 demo、较小的 bugfix 都可以直接提到 `master` 分支;新需求以及任何你不确定影响面的改动,请提交到对应“领域”的分支(`ios`、`android`、`jsfm`、`html5`)。
    
    查看完整的[分支策略 (英文)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)。
    
    -->


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jondong/incubator-weex WEEX-74

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/751.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #751
    
----
commit 634c6413c1e715cb3174b1b039198f339df25736
Author: Jonathan Dong <dong.yan@aliyun.com>
Date:   2017-09-27T15:18:51Z

    [WEEX-74] Added Jira issue number as commit log title
    
    As Apache Jira provides the function that can automatically connect
    commit and Jira issue according to the issue number with specific
    format, so added a new way in commit message title check regex to
    allow this.
    
    Removed the Merge title because we are not going to allow merge
    and start to follow the rebase way.
    
    Also updated error message to point to the correct URL.

----


> commit-msg in git hook should allow user to submit commit with title [WEEX-xxx]
> -------------------------------------------------------------------------------
>
>                 Key: WEEX-74
>                 URL: https://issues.apache.org/jira/browse/WEEX-74
>             Project: Weex
>          Issue Type: Improvement
>          Components: Project 
>            Reporter: Jonathan Dong
>            Assignee: sospartan
>            Priority: Minor
>
> According to the current commit log policy, people can only submit commit with the title:
> {action} [{module}] {description}
> more details can be found [here](https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#commit-log)
> As we decided to re-adopt Apache's Jira to track project's bugs and features, we hope
we can use the auto-correlation feature to automatically connect commit with Jira issue by
setting your commit log title with "[WEEX-xxx] <commit title>". So it is needed to change
the commit-msg git hook.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message