Mailing-List: contact user-help@uima.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@uima.apache.org
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Subject: Re: Question on JCasUtil's selectCovered(...)
From: Martin Wunderlich <martin_wu@gmx.net>
In-Reply-To: <3068CEC8-F7B4-4745-B46F-CE96CDB6EA9A@apache.org>
Date: Sun, 2 Aug 2015 09:33:48 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <5F69701A-A267-41D3-8C7E-F9074201E747@gmx.net>
References: <FAC3694D-0195-4050-8A36-20913CEF25AE@gmx.net>
 <86AA3201-17E2-4BE3-B403-D022166ABF70@apache.org>
 <04AE2318-23A0-4BB0-966E-7E693751884B@gmx.net>
 <3068CEC8-F7B4-4745-B46F-CE96CDB6EA9A@apache.org>
To: user@uima.apache.org

Thanks a lot, Richard. It is working fine now after making the changes =
suggested by you. Looks like I need to read up on Generics a bit...

Cheers,=20

Martin
=20

> Am 02.08.2015 um 00:09 schrieb Richard Eckart de Castilho =
<rec@apache.org>:
>=20
>=20
> On 01.08.2015, at 23:06, Martin Wunderlich <martin_wu@gmx.net> wrote:
>=20
>> Yes, I think you might be right, Richard, and that the problem is =
with the use of Generics.=20
>>=20
>> This would be the concrete FE class:=20
>>=20
>> public class StartingPositionOfPremiseUFE<Premise> extends =
StartingPositionOfPropositionUFE {
>>=20
>>   public static String FN_STARTINGPOSITIONOFPROPOSITION =3D =
"StartingPositionOfPremise";
>>=20
>> 	@Override
>> 	List<Premise> getPropositions(JCas jcas, int start, int end) {
>> 		return JCasUtil.selectCovered(jcas, Premise.class, =
start, end);
>> 	}
>> }
>=20
> I don't see why you would define <Premise> here on the subclass. You =
would either define a type variable on the subclass or bind a type =
variable on the superclass, so:
>=20
> public class StartingPositionOfPremiseUFE extends =
StartingPositionOfPropositionUFE<Premise>
>=20
>> The call to selectCovered(=85) gives the described error. The method =
getPropositions(=85) is defined as abstract in the super-class, which =
looks like this:=20
>>=20
>>=20
>> abstract public class StartingPositionOfPropositionUFE<T extends =
Proposition> extends FeatureExtractorResource_ImplBase implements =
ClassificationUnitFeatureExtractor{
>> 	...
>>   public List<Feature> extract(JCas jcas, TextClassificationUnit =
classificationUnit) {
>>   	List<? extends Proposition> props =3D (List<? extends =
Proposition>) getPropositions(jcas, start, end);
>=20
> Instead of <? extends Proposition>, I think you should be using <T>.
>=20
>>       if( props !=3D null && props.size() > 0) {
>>       	Proposition firstProposition =3D props.get(0);
>>       	startingPos =3D firstProposition.getBegin();
>>       }
>>=20
>> 	List<Feature> featList =3D new ArrayList<Feature>();
>>       featList.add(new Feature(FN_STARTINGPOSITIONOFPROPOSITION, =
startingPos));
>>=20
>>       return featList;
>>   }
>>=20
>>   abstract List<?> getPropositions(JCas jcas, int start, int end);
>=20
> Again, instead of <?> I think you should be using <T>.
>=20
>> }
>>=20
>> I=92ve removed the irrelevant bits to make it more concise.=20
>=20
> I still don't see why you would get that error though.=20
>=20
> Are you sure that "Premise.class" resolves to the right class here and =
not to another class which accidentally has the same name?
>=20
> -- Richard