From users-return-7627-archive-asf-public=cust-asf.ponee.io@trafficserver.apache.org Wed Mar 20 16:54:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2C74818077A for ; Wed, 20 Mar 2019 17:54:10 +0100 (CET) Received: (qmail 468 invoked by uid 500); 20 Mar 2019 16:54:09 -0000 Mailing-List: contact users-help@trafficserver.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@trafficserver.apache.org Delivered-To: mailing list users@trafficserver.apache.org Received: (qmail 457 invoked by uid 99); 20 Mar 2019 16:54:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2019 16:54:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 85FB2180A6D for ; Wed, 20 Mar 2019 16:54:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.201 X-Spam-Level: X-Spam-Status: No, score=-0.201 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=wikimedia.org Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 0Vjui1QzCtWI for ; Wed, 20 Mar 2019 16:54:06 +0000 (UTC) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id CAE5260D79 for ; Wed, 20 Mar 2019 16:45:31 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id h22so2587865edw.7 for ; Wed, 20 Mar 2019 09:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wikimedia.org; s=google; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=NmBKu59Gzarob7BcrPD9y6OUhLt4chlB26uxtzhZXWM=; b=eVZeCcGCH0RHwtH4gNe+qMIlPXdu2EZD8MwOQY9eJnYjIWfX8pEjLl3MPdlP84qtD6 h5pk94KQeN1Rkj+ANc0cJKEPe+NsMrHV2RCrxOlxhAWHqaJAbQZqaHBHW/I/MfTiUlG3 dlxOhyTMDS2ut9g8ooELsxKQ2b6/vjf10xQXs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=NmBKu59Gzarob7BcrPD9y6OUhLt4chlB26uxtzhZXWM=; b=BIXgnXvpz5o2gX+jB8w9c6Rxf2VN0Ia59J6ojkTdY9nyA82328vAWIOcfyNPQt3HRU I+bSIdZACNL3ficC9bvbJawIV/KiBBaTC1eJP72Y9p2KyxpgyihMRXtxo1tTEE+pa++r qT9Jf2gcbHrkSz8CYUScjDQJQWAY5ykOKm+JYL5QH1FII3NkIK2iMOkR+NjRhhY+nWdS 4PrksNYg+bMKZOW6XTJCo+ApHShAzex5Lgc0gn3guyH+zc9twf610FGI8qWFZOUXAPyq 98tFVhSeumYia7y4BE6VGMZDthG9bzKMsAWuCdJTCqdLHEQM9EWKYm+bQrqQ1ZB6h+Px 81Ww== X-Gm-Message-State: APjAAAWyPseAu8zi1nYE1vEwFa/GToIUGLQicDeciR7KGtwTqLiDjiXD VQfekrclQDmXKfysziZL3UWNxETsqK8= X-Google-Smtp-Source: APXvYqxJATOCwUpGbTBSeABY/q/DzuD5M90+nB+Vwr5pj1ZrkR/8Bm5382/McNd+TYGCVgar9XRqEQ== X-Received: by 2002:a17:906:6ada:: with SMTP id q26mr17578095ejs.138.1553100331155; Wed, 20 Mar 2019 09:45:31 -0700 (PDT) Received: from ariel (x4e370884.dyn.telefonica.de. [78.55.8.132]) by smtp.gmail.com with ESMTPSA id y24sm786007eds.35.2019.03.20.09.45.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Mar 2019 09:45:30 -0700 (PDT) Date: Wed, 20 Mar 2019 17:45:28 +0100 From: Emanuele Rocca To: users@trafficserver.apache.org Subject: total_server_connections incremented by plugins Message-ID: <20190320164528.GA16663@ariel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) I'm a bit confused by the total_client_connections and total_server_connections metrics. My understanding is that total_client_connections refers to inbound connections made to ATS, while total_server_connections is about outbound connections made by ATS to origin servers. I do however see proxy.process.http.total_server_connections increasing each time there's an inbound connection handled by plugins such as stats_over_http and healthchecks. The metric is incremented by HttpServerSession::new_connection, and I see the following backtrace for *actual* new origin server connections: 0x506120 : _ZN17HttpServerSession14new_connectionEP14NetVConnection+0x0/0x400 [/usr/bin/traffic_server] 0x4f0fa7 : _ZN6HttpSM22state_http_server_openEiPv+0x6a7/0x890 [/usr/bin/traffic_server] 0x4e2c02 : _ZN6HttpSM12main_handlerEiPv+0x1b2/0x260 [/usr/bin/traffic_server] 0x688ac0 : _ZN18UnixNetVConnection9connectUpEP7EThreadi+0x300/0x4a0 [/usr/bin/traffic_server] 0x681260 : _ZN16UnixNetProcessor19connect_re_internalEP12ContinuationPK8sockaddrP12NetVCOptions+0x5b0/0x730 [/usr/bin/traffic_server] 0x4ea3b5 : _ZN6HttpSM19do_http_server_openEb+0x1945/0x1ec0 [/usr/bin/traffic_server] Connections that end up incrementing the metric due to plugins have a different backtrace: 0x506120 : _ZN17HttpServerSession14new_connectionEP14NetVConnection+0x0/0x400 [/usr/bin/traffic_server] 0x4f0fa7 : _ZN6HttpSM22state_http_server_openEiPv+0x6a7/0x890 [/usr/bin/traffic_server] 0x4e2c02 : _ZN6HttpSM12main_handlerEiPv+0x1b2/0x260 [/usr/bin/traffic_server] 0x64d119 : _ZN12PluginVCCore10connect_reEP12Continuation+0x89/0x120 [/usr/bin/traffic_server] 0x4e8d1a : _ZN6HttpSM19do_http_server_openEb+0x2aa/0x1ec0 [/usr/bin/traffic_server] This seems a bug to me (I'd expect total_server_connections not to go up when the connection is handled by stats_over_http.so / healthchecks.so), but please do let me know if I am missing something.