On Fri, Aug 2, 2013 at 4:33 PM, Leif Hedstrom <zwoop@apache.org> wrote:

On Aug 2, 2013, at 9:49 AM, Yunkai Zhang <yunkai.me@gmail.com> wrote:

So many users forgot to set "proxy.config.allocator.enable_reclaim" to 1 after they compiled ATS with --enable-reclaimable-freelist option.

They were confused by "enable_reclaim" option, I think we should make it to 1 as default.

Seems reasonable to me. Alternatively, how about making it such that you expand it to "1" if the --enable-reclaimable-freelist option was given? That ought to be really easy to do, and avoids confusion. 

In fact, I'd recommend you doing it such that you *only* have these configurations in the default records.config.default.in *if* the configure option is enabled. Same with the SSD patch IMO.


There is a little hard to *hide* reclaimable-freelist configurations in records.config.default.in. And there are enough comments for user:

##############################################################################
#
# Configuration for Reclaimable InkFreeList memory pool
#
# NOTE: The following options are not meaningful unless compiles TrafficServer
#       with '--enable-reclaimable-freelist' option. Looks like:
#       $ ./configure --enable-reclaimable-freelist
#
##############################################################################
....

So, I don't want to hide it, but just as you suggested above, I'll make "enable_reclaim" expand to "1" only when "--enable-reclaimable-freelist" option was given.

 

-- Leif




--
Yunkai Zhang
Work at Taobao