From dev-return-209395-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Tue Jun 2 22:34:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DFE3318064C for ; Wed, 3 Jun 2020 00:34:06 +0200 (CEST) Received: (qmail 81046 invoked by uid 500); 2 Jun 2020 22:34:05 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 81036 invoked by uid 99); 2 Jun 2020 22:34:05 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2020 22:34:05 +0000 Received: from bz-he-de.apache.org (bz-he-de.apache.org [148.251.237.210]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTPS id E87C2E013F for ; Tue, 2 Jun 2020 22:34:04 +0000 (UTC) Received: by bz-he-de.apache.org (ASF Mail Server at bz-he-de.apache.org, from userid 33) id A92AC6A006C; Tue, 2 Jun 2020 22:34:03 +0000 (UTC) From: bugzilla@apache.org To: dev@tomcat.apache.org Subject: [Bug 64488] EL API: AccessControlException -- Import Handler Date: Tue, 02 Jun 2020 22:34:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Tomcat 10 X-Bugzilla-Component: EL X-Bugzilla-Version: 10.0.0-M5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: markt@apache.org X-Bugzilla-Status: REOPENED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@tomcat.apache.org X-Bugzilla-Target-Milestone: ------ X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bz.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 https://bz.apache.org/bugzilla/show_bug.cgi?id=3D64488 --- Comment #6 from Mark Thomas --- Thanks for the test case. It makes debugging what is going on a lot easier. I think there is a bug here. Over time we have added various optimisations to the ImportHandler to addre= ss performance issues caused by the ambiguity introduced in EL 3.0. A good sum= mary of those ambiguities and the associated performance issues can be found in https://tomcat.markmail.org/thread/pcxxg4ql6mxjwcmd and the links in the fi= rst email of that thread. One of those optimisations was to do a resource lookup before trying to load the class as this was considerably quicker for the "not a class" case and o= nly marginally slower for the "is a class" case. It is this resource lookup tha= t is failing due to a lack of read permission. Given that this test is there to optimise the "not a class" case, that the return value is thrown away and that the class loading happens a few lines later, I think your proposed patch is along the right lines. We've been mov= ing towards removing anonymous classes so I am going to try a variation of your patch that uses an inner class. --=20 You are receiving this mail because: You are the assignee for the bug.= --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org