tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 64488] EL API: AccessControlException -- Import Handler
Date Tue, 02 Jun 2020 22:34:03 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=64488

--- Comment #6 from Mark Thomas <markt@apache.org> ---
Thanks for the test case. It makes debugging what is going on a lot easier.

I think there is a bug here.

Over time we have added various optimisations to the ImportHandler to address
performance issues caused by the ambiguity introduced in EL 3.0. A good summary
of those ambiguities and the associated performance issues can be found in
https://tomcat.markmail.org/thread/pcxxg4ql6mxjwcmd and the links in the first
email of that thread.

One of those optimisations was to do a resource lookup before trying to load
the class as this was considerably quicker for the "not a class" case and only
marginally slower for the "is a class" case. It is this resource lookup that is
failing due to a lack of read permission.

Given that this test is there to optimise the "not a class" case, that the
return value is thrown away and that the class loading happens a few lines
later, I think your proposed patch is along the right lines. We've been moving
towards removing anonymous classes so I am going to try a variation of your
patch that uses an inner class.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message