From dev-return-203679-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Fri Nov 22 19:49:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0E9CA180629 for ; Fri, 22 Nov 2019 20:49:47 +0100 (CET) Received: (qmail 32355 invoked by uid 500); 22 Nov 2019 19:49:46 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 32344 invoked by uid 99); 22 Nov 2019 19:49:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Nov 2019 19:49:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4CDDA180D7B for ; Fri, 22 Nov 2019 19:49:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=christopherschultz-net.20150623.gappssmtp.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id K-7vCFND5pXb for ; Fri, 22 Nov 2019 19:49:41 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.219.67; helo=mail-qv1-f67.google.com; envelope-from=chris@christopherschultz.net; receiver= Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 79EF9BC530 for ; Fri, 22 Nov 2019 19:49:41 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id n12so3398602qvt.1 for ; Fri, 22 Nov 2019 11:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=christopherschultz-net.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ru+qpchdFKywdXG1FNjV1hb6oYA0b7UZyBL7m9RG5+w=; b=NH5pCwwWh9rhK0rYMn2ipAiHFQCaIbMqd1+7zQX5riquHVfNwNMCzE809E/W7KiDb9 P5fkp0Xr+7gn1KXTE1SikQe606L3tGkB8VjVf7hj1wxOG8lzkEkHRMR9ADCBZGmFyIM0 YYhpq/DkU2/aaNBp6Kho6016ypCKLMaapQRUpocpGGs11n1l9hiVhMgoZzkQze3j9RJj kPc1DL8lqniVkTdzVJ6QAfHoK8aM+qy0xfNb3dgE8BypH29Oi9gq5MkckDQonCReuW/a 2THzLGxGo7DJ81CyPwsYu2XwvJLWXOa8c82y6vjnaqCFyfJ7z/P3T3YsvThmeHhz0c3W yPtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ru+qpchdFKywdXG1FNjV1hb6oYA0b7UZyBL7m9RG5+w=; b=cJK+92nJUCRkKzYtdBeCDQd0UX83loqYzruyt7veLQBEkN36rX6j6R8f52kosOo+e3 57mOfN17szpEl4jZckszJ96vPCLvvda9d1r4YfYCnY6MioMDrRaVpFmoFtutWHcJ43m3 tW9RLWjzwJHlzYw+4N6yGH6oZY9OnS8FiS1lUntC4TBZfTMw9GU98UWYDamuXVk0z/im NykS3kNEDmQAqiVVpiYm2UD3y67M5su8USIhCzPjQccwWEShgBVuNdDlL0lKcDG/I/RN J33BGP0I8T1nlzMJKRItikSTNO1jSqOV06xgJSDbR3gZVPa5G39J/VUOOB52IbvU1C01 mgRg== X-Gm-Message-State: APjAAAXOJOki31DsOP03Htzssl3ahA7lZ6yqOMS8tgYEh6Bn1oZXU+kH e76UkfZJ6X5iveOaopef93W12Z7ch20= X-Google-Smtp-Source: APXvYqxEQAjHfnQ6ijNZv6Q/dWfdHfnUGHvXIKiKwSfvAj/B9jkWCwAXpV8EjI5uxb9cI5g1ZCZjIw== X-Received: by 2002:a0c:baad:: with SMTP id x45mr15343793qvf.230.1574452180687; Fri, 22 Nov 2019 11:49:40 -0800 (PST) Received: from Christophers-MacBook-Pro-2.local (pool-108-48-175-111.washdc.fios.verizon.net. [108.48.175.111]) by smtp.gmail.com with ESMTPSA id z3sm3901513qtu.83.2019.11.22.11.49.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 11:49:39 -0800 (PST) Subject: Re: [tomcat] branch 8.5.x updated: Add RFC references. To: dev@tomcat.apache.org References: <157435647699.10727.3035394053660800986@gitbox.apache.org> From: Christopher Schultz Openpgp: preference=signencrypt Autocrypt: addr=chris@christopherschultz.net; keydata= xsFNBE+pgz4BEADd7qAWgqXcNltlB3aow0UneRmNSVjHKgekgs0ZXxG9l50Athksr/3bL/yg bxFB00JcM9W+UxLhKHiMSyzfeBHn9l9wAlLFKs0S91KXTUnRwGFtvgstvGROoqPgTVREklnm yW/KpzOwqSrQ5xHcogaT+XWlXmRbtFypi52Z5HGWlFWWgwx0vKBWHmQayPtCif0v1RDxfdV9 zziodn0TnpfBQsEgf9TDAjkNT8f0ecwTnhSihTDm1W5HCK7Pm5DfUtree1Oh6Ncz2ljlUO0b 3Lai9pX48eZOj7WQXPefkcv2AoUvdELkQKw3klM5YNXbXPf1KAjky+q4DQ1ydD6LkK+9cI3S TeMesTlk/tytOsaN2NH2k87sEpcumbH0AcmPFEnIYUfm4KzWdKlYA6mbV3Pk3tHSuayyJovj h/7Y7BG9p2l7D60r49hzrTPG8VxNkSliNLcSjI3QjYpfhSlqmqXyVKzdzirK1HPr1xfJStig RpLP9nWarZjoXng9N0etGwtH/8roeDPYA8x9ba1KXy/1g/i+RLx2ms+rueCpnFZxU3GZNUSp RfpdUbwCN3Zm1w5Z6SI8X2aSnWWeYzU6HMsV+P4PROnFsgxDeOpyWhyEaaVLXQtOYwcHneHb n56vSG50TkAuHs5kk/3/YDPSsqjsUPOuhKgFMh3iqMTh5DMdSwARAQABzTJDaHJpc3RvcGhl ciBTY2h1bHR6IDxjaHJpc0BjaHJpc3RvcGhlcnNjaHVsdHoubmV0PsLBegQTAQgAJAIbLwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAUCT6mETgIZAQAKCRDzrVyUpn9wflkxD/9IsahRqHTV /hH5nuPqVO692cQqHvPtMPO6lDb4909VN5T1i+1hFr80P0KVDL6EI78lDBJ2TThWI0o5vFdm sRlei59wsgTvkKTph5QwwOWl7OyzUDX3WbKhkNQdGf4I+/g/1s2bHaRoG30ELdL7cwUPCPrW 0KQwBy7Rtr0WbdujKOw9b/UcgyXEOE1wNcorq/E1o5/6BRYIcFQOO4sjHjGcChOpSg5ms4zb s+Xv3gOtLrbmOPRTXdvBxwJA6kkfQFHvI42kXYghTdqhBVPnHYPqUeavRsb+Yz3ghkZhj35i GfaGyXNwFBikCYjzIaj44NOkT1pU50MgIbjSJ+xoHnC20T942kekqp6wzqUM19Pa9ohsEdA1 Sf6/A7RmpZRrxSIY02ZVnGccnVjglnylVcnxrNAZC3ebxCeZPQ09FBR0Uqlsrdt7A3hlEP2F aoMTSa+hYqfWBGB7uZhcJZIsZspxm8J0txeOzYNSFDl7mF134ShRsq6dpSugCdcdeSWKliBz q0U8sIabOFLMxM0hbwkn2RG4OaurJLWXQf+7IhA/J8TizjkbdxLmR2PiTiVtrx484mpWpbF8 po/em0q/reFnL+JtOM6qlJE/Q4B6PfkchhU5vKPfmGw98t9guyw5G8YSR1rR+SOowHg4T/i2 Rezz1idKmoFpPdNFRPlOAC+d687BTQRPqYM+ARAAzEItVpzvcgZB+faUWi54lJoA8GnVxXEe OQY+7wk/P5i9GtL0UVXC53j2F87BDVXGalKgVjEVdNY3Cyx+dJ2os65gjxd6ZK18zc6N7YZB Z00XNU9nTz5XImZzHn4VmeXYMQrKO/981nCNPlV6CVdgGg9wl1Ij5Sh8SSTb8kWSo1ngx+XX 4yJNUbfSh32yMPVGI7ZcoZLm9gdgTOOnuEkeeGs/lPvYN+1Cv/YtvkPybSOSWSdHxIVU4Iko 6V7IkM1amjdwKfoeg+CLhZsbY7VLAzVtGvaF5z4rtJtCfTfhbYD0wS8afEBcvsew1HdtYDT5 AJqojeZBGDuY7JCgALc3HCy34Zzk+mi1qwvrm5i/CBMuIvjxB2MkzhHQNUD20fzdRcoIgw4J IzbqZLlOpVFehDXzKT/h5vh+Uv7s6Rz5gP5i0Rkcghw00mRBvuN8mpQnLt4hYL22cNh/tk0L Fxda7ZaPehu7ug4E5FEB0Ifm1KV18P7Kpfu8tiSLz7rl++x73o4uv4bk1ZnjO/jFsx0KLGwq VxR276ZIwsV4WpLYvJ5fR0kqqd/TOKXGSEA0eGxWTeb/fNtkYemRVoasB1+rqjh/Rz0p20o8 elkqDhpzzhrMNzEMYkLySu7npWCeWW4Nd6097+OG9BCLO+ndGmAcupdu6WMEj2UlWsQxuCYC PgsAEQEAAcLDfgQYAQgACQUCT6mDPgIbLgIpCRDzrVyUpn9wfsFdIAQZAQgABgUCT6mDPgAK CRAc8Ck/pTykWO6WD/0XlAG4D4GwzzuOfh7DG6cm/I0vmASEJkY5ghStW4GUbYosgS/btyj/ YPWzVh4HWMvuA6YYKCuz/CM3h34dR25XmHqUdOyJOCnMJ3psdv5YsytgnEdvINZALlDdBX3G sfytgS0KnVjAc92LfJOxHAsZf4zE3SU28FMX7jCgeqO3YrvkHsZ8dzzgw3QYT0J3NcYfkflb DPBXBDGrvdUuea/w6F17pctdRdt7jE3JiLFq2F9ehXOSsIwecUlqVYiCRuxblD4cJ6gKMn0y 8zllW4GyIbf/+mNLkpKoMPYnptDvcEojluHtwbkSfF5AwgJbm6pfs9a2vpGBVko+dBXGh4/T 3qNYxeGEAsI0psEJu3EZN9dYv/ZOb69DUJ6SwEKp/L7lU7C8HoLx/MpKtuJO9OS5uuAhdBSi GqfaN9zP2NxPXSwnexVK2exy/h5sUevDsnBEHmyxe5GRSrIilyijLtlYhq2W7G95poxIFZuL Db98R+7VR9Yl9uOZ6kRBJmzp9X2oB8MDHoKe4QEuiRx/5/DNxB8i2QoTWN/BfluTSfVpO5rf jSXlaUuFOnouBrWdmbaBdg+47m4IGEz129Zdf+y+ISexQ6P16ZY1oYxYlbQSaEwk0+TJ4B0C uvMHwPF3SDH2LeRx+mK2OvwnVulvj2+WdW/rIVgwhwbKmBLj40R+Uq4zD/4iRxJ5PF1ynjxR po3Izp/ZrYWrPgtBg0jUZ8DdlAiRHCFGPpccK8RvBWXmtzF4XQsV39aPBqcE3W6IcTnIMrDi 6mnqealpfiUq+4RGNfRFN9wtgViZLy/FRWi76k+vo/Jmp7/K9JblGX48D2JL9FX0w5PXkpE4 abmY1OASQUiwoJ4n1asxwEonSaWeYbI7X5IqdvevGyfYdSn4VEywdrYGtWjsWlZ/DPofPwsI bQXGY6o+wg9lDAk2L2nVTa05XuyOooUPwKLD0WrLOIxLmcbVv/tgJG03/uI4iDitSofTKnpz E+xdpfFIyw1Mb8PO4WJi0gpHmmLUbG8AMLS+8wSDFwIA4TXQFy9suXXzLuuzML+G5h9Mo5D6 q5HsIe59lhdwk7oEPZJ1NWLfLavTENQg5ObS2YT1KaFskFxxgtcU0aBytAxTjkgGRB8UunXl NJeCuTIAUxXw41P93V4Khigc5dEOG1kEDoq0dAlAE7AbL6Vzc/Go+UwivtUil3sXADOyM9PT JjLNnye+2V0ywQncJ1AG6sxICpPKzv8oYP6xwurEuKnF8DAWEHEwT+Fb277Idv1v8uMGvltp coe7olE0O+TRUtMEwtEp4g4m8ym1rJI/yfwXtHkS8QcVBA9LRqcWEna1VPlT1pk3BSq/1xQa F/4OLScBfV2JbF93sN0SLw== Message-ID: Date: Fri, 22 Nov 2019 14:49:38 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:55.0) Gecko/20100101 Thunderbird/55.0a1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Konstantin, On 11/21/19 12:36, Konstantin Kolinko wrote: > чт, 21 нояб. 2019 г. в 20:14, : >> >> This is an automated email from the ASF dual-hosted git >> repository. >> >> schultz pushed a commit to branch 8.5.x in repository >> https://gitbox.apache.org/repos/asf/tomcat.git >> >> >> The following commit(s) were added to refs/heads/8.5.x by this >> push: new fdf0ba0 Add RFC references. fdf0ba0 is described >> below >> >> commit fdf0ba0aaebaffd588077defea0f56d6ba81396e Author: >> Christopher Schultz AuthorDate: >> Thu Nov 21 11:17:54 2019 -0500 >> >> Add RFC references. --- >> java/org/apache/catalina/servlets/WebdavServlet.java | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/java/org/apache/catalina/servlets/WebdavServlet.java >> b/java/org/apache/catalina/servlets/WebdavServlet.java index >> ef5573d..f870443 100644 --- >> a/java/org/apache/catalina/servlets/WebdavServlet.java +++ >> b/java/org/apache/catalina/servlets/WebdavServlet.java @@ -61,7 >> +61,10 @@ import org.xml.sax.InputSource; import >> org.xml.sax.SAXException; >> >> /** - * Servlet which adds support for WebDAV level 2. All the >> basic HTTP requests + * Servlet which adds support for + * > href="https://tools.ietf.org/html/rfc4918">WebDAV + * > href="https://tools.ietf.org/html/rfc4918#section-18">level >> 2. + * All the basic HTTP requests * are handled by the >> DefaultServlet. The WebDAVServlet must not be used as the * >> default servlet (ie mapped to '/') as it will not work in this >> configuration. *

@@ -120,6 +123,8 @@ import >> org.xml.sax.SAXException; * >> http://host:port/context/webdavedit/content * * @author Remy >> Maucherat + * + * @see https://tools.ietf.org/html/rfc4918 */ > > This change triggered a compilation failure at Buildbot, see > https://ci.apache.org/builders/tomcat-85-trunk/builds/2053 > > IIRC, if a plain URL is used in a '@see' tag it should be in double > quotes, @see "https://tools.ietf.org/html/rfc4918" Thank you for the review. I didn't check javadoc warnings before committing. Here is the documentation for @see: https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.ht ml#see Should I instead use: @see ... ? - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl3YO9IACgkQHPApP6U8 pFg0QQ/8C3fJ9P6JVQdr3KyuZe23wnmxhJlvX8BSwL1GV7swpXufxF+zatsAjvzT WTXwkmiXjSGtan+a9mG6qvUv2y3EQjvZtxrTzltd1R3AN8A/noY7Q6LcgZjHswS5 6mOMNq52VuGkH28UXkpTp3/zXi1893kHwSqxwtpgUGcgpS7Be/+CCvbo4NPzDHkl YW5XuDrGQITgXjtELYUoYhl4qmakjQCesy3pG9C9IcewQ0eHm9j2ToiSSo30BOSF yisUcub1jDSWyfiJjb4zl8gLklCmYtPdIroUdoTy1rBigv6yZ8UuSlA5uVvmvEYc sIE3S/tIaxZgqsrvB2+oGvvO/JlkEboomeMnJaZFRPAstsm6uU2vpa9BOr4MLG81 Wi3m2LoOxxpGRhpE0i/U+ue4RcGIaaAyjFMDPqVuvXBwhPF80ozKdebMQ3gGW2mu ItMZnukD5k3IrR94AMMJq5v1KT8Hr3jf5qX4FY3ubGrAuZZwmuPZY5gT3Iq9LECi TmHWeHSUu368wSBYvC/aaAc4rEX3rFx2uR8irAtNPf9wIEMLg8GMC0pusUCfPsLt NQLtFqE4ZWt4I+wI8q603Z8H+VX1fVzKU9MBZ6SnnUmx0lWSAqRRMiMNDCmq7qlD 24eSUh7irr1omJYtKB/WuWQsvp5bnNFavxJAO2e55ccc6JJ07l4= =9b3w -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org