From dev-return-203500-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Tue Nov 19 09:36:56 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0F681180638 for ; Tue, 19 Nov 2019 10:36:55 +0100 (CET) Received: (qmail 78874 invoked by uid 500); 19 Nov 2019 09:36:54 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 78864 invoked by uid 99); 19 Nov 2019 09:36:54 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2019 09:36:54 +0000 Received: from bz-he-de.apache.org (bz-he-de.apache.org [148.251.237.210]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTPS id D5484E0E2E for ; Tue, 19 Nov 2019 09:36:53 +0000 (UTC) Received: by bz-he-de.apache.org (ASF Mail Server at bz-he-de.apache.org, from userid 33) id 906E46A0068; Tue, 19 Nov 2019 09:36:52 +0000 (UTC) From: bugzilla@apache.org To: dev@tomcat.apache.org Subject: [Bug 63932] Content compression breaks contract of ETag Date: Tue, 19 Nov 2019 09:36:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Tomcat 9 X-Bugzilla-Component: Connectors X-Bugzilla-Version: 9.0.x X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: michaelo@apache.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@tomcat.apache.org X-Bugzilla-Target-Milestone: ----- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bz.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 https://bz.apache.org/bugzilla/show_bug.cgi?id=3D63932 --- Comment #7 from Michael Osipov --- (In reply to Mark Thomas from comment #5) > Please take care, as Julian did, to be specific about whether you are > talking about weak or strong validators. >=20 > RFC 7232 states (section 2.1) > > Likewise, a validator is weak if it is shared by two or more > representations of a given resource at the same time, unless those > representations have identical representation data. For example, if > the origin server sends the same validator for a representation with > a gzip content coding applied as it does for a representation with no > content coding, then that validator is weak. > >=20 > So the Default servlet (that only ever sets a weak ETag) is fine. As is t= he > WebDAV servlet. I agree. Is there a possibility that a custom resource is added to the cont= ext with issues strong validators? > Where things get "interesting" is when resources set their own, strong ET= ag. > It looks to me that the simplest solution would be for the container > provided compression to check for the presence of a strong ETag and, if it > finds one, prepend the weakness indicator to the ETag if it is going to > compress the resource. That would be wrong, imho. The servlet expects the ETag to retain strong and not to be modified in terms of comparison strength. --=20 You are receiving this mail because: You are the assignee for the bug.= --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org