From dev-return-203577-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed Nov 20 16:51:42 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 701031804BB for ; Wed, 20 Nov 2019 17:51:42 +0100 (CET) Received: (qmail 33007 invoked by uid 500); 20 Nov 2019 16:51:41 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 32997 invoked by uid 99); 20 Nov 2019 16:51:41 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.42) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2019 16:51:41 +0000 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id F16A91004 for ; Wed, 20 Nov 2019 16:51:40 +0000 (UTC) Received: by mail-yb1-f180.google.com with SMTP id g38so200240ybe.11 for ; Wed, 20 Nov 2019 08:51:40 -0800 (PST) X-Gm-Message-State: APjAAAV4USaqF9UpbmdIzc3OVlU6YdpQMftpGr+qehRzxBWyQ5rHXTea VNkZBfyPLoGh/FtEivvPSIEEjTmSz4cXeAaDB+M= X-Google-Smtp-Source: APXvYqxhh+Kro9Imr+T7QTFYCddoY6a/AJzqqbMsXe/GXD241kXo6Zu2vkMdkhU0UqoY0SZ59EAxGMvBkNYDbteupoY= X-Received: by 2002:a25:1646:: with SMTP id 67mr2730773ybw.485.1574268700680; Wed, 20 Nov 2019 08:51:40 -0800 (PST) MIME-Version: 1.0 References: <157426788971.11546.1858282774433175011@gitbox.apache.org> In-Reply-To: <157426788971.11546.1858282774433175011@gitbox.apache.org> From: =?UTF-8?Q?R=C3=A9my_Maucherat?= Date: Wed, 20 Nov 2019 17:51:29 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [tomcat] branch master updated: Correct the docs for maxConnections To: Tomcat Developers List Content-Type: multipart/alternative; boundary="000000000000af693a0597c9fe17" --000000000000af693a0597c9fe17 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 20, 2019 at 5:38 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > View the commit online: > > https://github.com/apache/tomcat/commit/33e01c97e24e2ccbe1392a2294e77619d= 8983fdd > > The following commit(s) were added to refs/heads/master by this push: > new 33e01c9 Correct the docs for maxConnections > 33e01c9 is described below > > commit 33e01c97e24e2ccbe1392a2294e77619d8983fdd > Author: Mark Thomas > AuthorDate: Wed Nov 20 16:33:54 2019 +0000 > > Correct the docs for maxConnections > Although the feature now actually works for NIO2 (it took a while ...), its default used to be -1 and it didn't cause problems. The default is now 10k for NIOx and 8*1024 for APR. I think it would be nice to change this to either: - Default to 8*1024 for all connectors, as it would remove one line of code and a convoluted comment in APR - Default NIOx to -1 R=C3=A9my --000000000000af693a0597c9fe17 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Nov 20, 2019 at 5:38 PM <markt@apache.org> wrote:
This is an automated email from the A= SF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomc= at.git


View the commit online:
https://github.com/a= pache/tomcat/commit/33e01c97e24e2ccbe1392a2294e77619d8983fdd

The following commit(s) were added to refs/heads/master by this push:
=C2=A0 =C2=A0 =C2=A0new 33e01c9=C2=A0 Correct the docs for maxConnections 33e01c9 is described below

commit 33e01c97e24e2ccbe1392a2294e77619d8983fdd
Author: Mark Thomas <markt@apache.org>
AuthorDate: Wed Nov 20 16:33:54 2019 +0000

=C2=A0 =C2=A0 Correct the docs for maxConnections

=
Although the feature now actually works for NIO2 (it took a whil= e ...), its default used to be -1 and it didn't cause problems. The def= ault is now 10k for NIOx and 8*1024 for APR.

I thi= nk it would be nice to change this to either:
- Default to 8*1024= for all connectors, as it would remove one line of code and a convoluted c= omment in APR
- Default NIOx to -1

R=C3=A9my<= div>
--000000000000af693a0597c9fe17--