From dev-return-203827-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed Nov 27 12:47:24 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6D898180648 for ; Wed, 27 Nov 2019 13:47:24 +0100 (CET) Received: (qmail 44167 invoked by uid 500); 27 Nov 2019 12:47:23 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 44157 invoked by uid 99); 27 Nov 2019 12:47:23 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.42) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Nov 2019 12:47:23 +0000 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id DC80E4FB4 for ; Wed, 27 Nov 2019 12:47:22 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id q18so8919483ybq.6 for ; Wed, 27 Nov 2019 04:47:22 -0800 (PST) X-Gm-Message-State: APjAAAWkZg2Gic44cq84nOeQILXzMtXqQWNNkgtfE6YHh3NX4pULmYuI I3hLfVmqGw8tQzWT6gR7s0wT2o+TpZdZxrX/LUw= X-Google-Smtp-Source: APXvYqzccLAbpItT3NPjOnHFFIPle3/5nwJP26pqg/U51aDgluSmiCkbcH0NknfW1zJ9EGSID86z0rBV0PMNjLaMPY8= X-Received: by 2002:a25:ab41:: with SMTP id u59mr33389957ybi.339.1574858842492; Wed, 27 Nov 2019 04:47:22 -0800 (PST) MIME-Version: 1.0 References: <092f3a47-1027-ee96-2c48-09211efcf2cb@apache.org> In-Reply-To: From: =?UTF-8?Q?R=C3=A9my_Maucherat?= Date: Wed, 27 Nov 2019 13:47:11 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods To: Tomcat Developers List Content-Type: multipart/alternative; boundary="000000000000e0da85059853659c" --000000000000e0da85059853659c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 26, 2019 at 2:36 PM R=C3=A9my Maucherat wrote= : > It looked ok and removed a big chunk of code so I went ahead with it. > Status update: > - This one, also the easiest one: drop > SocketWrapperBase.write(Non)BlockingDirect methods > Done. Updated port list: - Remove multipoller from the NIO connector. - Endpoint generics for the connection type (not fully mandatory but cleaner). > - Move the processor tracking to the wrapper and the connection map to th= e > endpoint; this one can improve performance > - The pile ups of close refactoring; big cleanup and move close to the > wrapper, also improves robustness, I would do it last > > R=C3=A9my --000000000000e0da85059853659c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Nov 26, 2019 at 2:36 PM R=C3=A9my Maucherat <remm@apache.org> wrote:
=
It looked ok and removed a big chunk of code so I = went ahead with it.

Status upda= te:
=C2=A0
- This one, also the = easiest one: drop SocketWrapperBase.write(Non)BlockingDirect methods
<= /div>

Done.

= Updated port list:
- Remove multipoller from the NIO connect= or.
- Endpoint generics for the connection type (not fully mandat= ory but cleaner).
- Move the processor tra= cking to the wrapper and the connection map to the endpoint; this one can i= mprove performance
- The pile ups of close refactoring; big c= leanup and move close to the wrapper, also improves robustness, I would do = it last

R= =C3=A9my

--000000000000e0da85059853659c--