From dev-return-203789-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Tue Nov 26 14:11:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1702318065D for ; Tue, 26 Nov 2019 15:11:12 +0100 (CET) Received: (qmail 29307 invoked by uid 500); 26 Nov 2019 14:11:11 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 29297 invoked by uid 99); 26 Nov 2019 14:11:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Nov 2019 14:11:11 +0000 From: GitBox To: dev@tomcat.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btomcat=5D_markt-asf_commented_on_a_change_in_pu?= =?utf-8?q?ll_request_=23225=3A_BZ_63681=3A_Introduce_RealmBase=23authenti?= =?utf-8?q?cate=28GSSName=2C_GSSCredential=29_an=E2=80=A6?= Message-ID: <157477747177.20110.7581643730275964197.gitbox@gitbox.apache.org> Date: Tue, 26 Nov 2019 14:11:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit markt-asf commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an… URL: https://github.com/apache/tomcat/pull/225#discussion_r350763014 ########## File path: java/org/apache/catalina/Realm.java ########## @@ -116,6 +118,17 @@ public Principal authenticate(String username, String digest, public Principal authenticate(GSSContext gssContext, boolean storeCreds); + /** + * Try to authenticate using a {@link GSSName} + * + * @param gssName The {@link GSSName} of the principal to look up + * @param gssCredential The {@link GSSCredential} of the principal, may be + * {@code null} + * @return the associated principal, or {@code null} if there is none + */ + public Principal authenticate(GSSName gssName, GSSCredential gssCredential); + Review comment: Or... Add method with default implementation to `Realm` in 9.0.x and add `GSSRealm` to 7.0.x and 8.5.x, implemented in `RealmBase` and marked as deprecated in 8.5.x. with removal in 9.0.x. I'm neutral at this point on whether `GSSRealm` needs to extend `Realm`. That gets everything in place one major version earlier. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org