From dev-return-203676-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Fri Nov 22 16:31:23 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B4383180629 for ; Fri, 22 Nov 2019 17:31:22 +0100 (CET) Received: (qmail 73373 invoked by uid 500); 22 Nov 2019 16:31:21 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 73363 invoked by uid 99); 22 Nov 2019 16:31:21 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Nov 2019 16:31:21 +0000 From: GitBox To: dev@tomcat.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btomcat=5D_michael-o_commented_on_a_change_in_pu?= =?utf-8?q?ll_request_=23225=3A_BZ_63681=3A_Introduce_RealmBase=23authenti?= =?utf-8?q?cate=28GSSName=2C_GSSCredential=29_an=E2=80=A6?= Message-ID: <157444028136.26658.2486147099054689865.gitbox@gitbox.apache.org> Date: Fri, 22 Nov 2019 16:31:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit michael-o commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an… URL: https://github.com/apache/tomcat/pull/225#discussion_r349685255 ########## File path: java/org/apache/catalina/Realm.java ########## @@ -116,6 +118,17 @@ public Principal authenticate(String username, String digest, public Principal authenticate(GSSContext gssContext, boolean storeCreds); + /** + * Try to authenticate using a {@link GSSName} + * + * @param gssName The {@link GSSName} of the principal to look up + * @param gssCredential The {@link GSSCredential} of the principal, may be + * {@code null} + * @return the associated principal, or {@code null} if there is none + */ + public Principal authenticate(GSSName gssName, GSSCredential gssCredential); + Review comment: That is true, but that would ultimately mean that it would be available in Tomcat 9+ only. SPNEGO support has been introduced with BZ 48685 which was fist implemented in 577c4e6194b71a63be70725bb743c94c7cb082cc and was included in these tags: ``` $ git tag --contains 577c4e6194b71a63be70725bb743c94c7cb082cc 7.0.12 7.0.13 7.0.14 7.0.15 7.0.16 7.0.17 7.0.18 7.0.20 9.0.0 9.0.0-M1 9.0.0-M10 9.0.0-M11 9.0.0-M12 9.0.0-M13 9.0.0-M14 9.0.0-M15 9.0.0-M16 9.0.0-M17 9.0.0-M18 9.0.0-M19 9.0.0-M2 9.0.0-M20 9.0.0-M21 ``` which basically means that the API has already been broken. I wouldn't mind to provide this to 8.5.x and 9.0.x only. Since 8.5.x and 9.0.x are interchangeable expect Servlet API it would be whise to have it either in both or in none. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org