From dev-return-203661-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Fri Nov 22 11:59:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7A7F8180629 for ; Fri, 22 Nov 2019 12:59:30 +0100 (CET) Received: (qmail 66640 invoked by uid 500); 22 Nov 2019 11:59:29 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 66623 invoked by uid 99); 22 Nov 2019 11:59:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Nov 2019 11:59:28 +0000 From: GitBox To: dev@tomcat.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btomcat=5D_markt-asf_commented_on_a_change_in_pu?= =?utf-8?q?ll_request_=23225=3A_BZ_63681=3A_Introduce_RealmBase=23authenti?= =?utf-8?q?cate=28GSSName=2C_GSSCredential=29_an=E2=80=A6?= Message-ID: <157442396886.31266.4600919512253586495.gitbox@gitbox.apache.org> Date: Fri, 22 Nov 2019 11:59:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit markt-asf commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an… URL: https://github.com/apache/tomcat/pull/225#discussion_r349559999 ########## File path: java/org/apache/catalina/realm/CombinedRealm.java ########## @@ -386,6 +387,38 @@ public Principal authenticate(GSSContext gssContext, boolean storeCred) { return null; } + /** + * {@inheritDoc} + */ + @Override + public Principal authenticate(GSSName gssName, GSSCredential gssCredential) { + Principal authenticatedUser = null; + String username = gssName.toString(); Review comment: This looks to be unnecessary. You should be able to use gssName directly in the logging calls. This could be cleaned up in the existing code too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org